feat: typescript everything #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first commit with composit projects and project references
- Typscript types are now available for all packages - Serialport no longer supports Node 10 - `baudRate` on `serialport` and `@serialport/stream` packages is no longer defaulted to 9600 - All parser packages now have named exports - Bindings have moved from `@serialport/bindings` to `@serialport/bindings-cpp` they are shipped with `prebuildify` and no longer require a download. - `@serialport/bindings-cpp` now leverages N-API and shouldn't need to be upgraded for every node release. - baudRate is now required - bindings and mock bindings now have a new interface with bindings-cpp - stream no longer has a list method - serialport package no longer has a static bindings property TODO - stop bits are incorrect from a bindings level to the port
HipsterBrown
reviewed
Feb 1, 2022
stuck on the 2k write test on an arduino - it seems to crash the poor thing, the mock bindings deal just fine. I'm going to copy the test into the bindings cpp repo becasue it's eiother an issue ther or with my hardware. mock binding now can give smaller read responses even if there is available data (much like a real port) find find-arduino too
composit packages only exist for builds not for general development
reconbot
commented
Feb 3, 2022
| "test:watch": "mocha -w", | ||
| "test": "nyc --reporter=html --reporter=text --reporter lcovonly mocha", | ||
| "typecheck": "tsc" | ||
| "typecheck": "lerna exec tsc" |
There was a problem hiding this comment.
I think this is better not sure -it's fast so nbd either way
| @@ -47,7 +58,7 @@ class SlipDecoder extends Transform { | |||
| } | |||
|
|
|||
| if (this.escape) { | |||
| if (byte === this.opts.ESC_START) { | |||
| if (byte === this.opts.ESC_START && this.opts.START) { | |||
There was a problem hiding this comment.
this is really the only functional change in parsers - it doesn't break tests and the code doesn't make sense or typecheck without it
reconbot
force-pushed
the
reconbot/typescript4
branch
from
e98b0c7
to
00a4537
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a huge pr, trying to get anything to convert to typescript piecemeal was very very frustrating and most of the conversions are straight copies.
However
@serialport/streamserialportFull change log
bindings-abstractis nowbindings-interfaceand it's in it's own repo (bindings-cpprelies on it and having a cyclic dependency on the monorepo was hard)baudRateonserialportand@serialport/streampackages is no longer defaulted to 9600@serialport/bindingsto@serialport/bindings-cppthey are shipped with -prebuildifyand no longer require a download.@serialport/bindings-cppnow leverages N-API and shouldn't need to be upgraded for every node release.