Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

callbacks not firing since bindings@2.0.3 #1756

Closed
Xapphire13 opened this issue Dec 27, 2018 · 1 comment
Closed

callbacks not firing since bindings@2.0.3 #1756

Xapphire13 opened this issue Dec 27, 2018 · 1 comment

Comments

@Xapphire13
Copy link

Xapphire13 commented Dec 27, 2018

Summary of Problem

Since version 2.0.3 of @serialport/bindings my callbacks are no longer firing.

  • What are you trying to do?
    • Use callbacks with .write(...) and .drain(...)
  • What happens?
    • Callbacks are never fired
  • What should have happened?
    • The callbacks should fire

Code to Reproduce the Issue

const serialport = new SerialPort(path);
// Assume we successfully open the serial connection
serialport.write([0x01], () => console.log("THIS NEVER FIRES"));

Versions, Operating System and Hardware

  • SerialPort@? 7.1.1 and 7.1.0
  • Node.js v? 8.11.2
  • Windows? Linux? Mac? Windows 10
  • Hardware and chipset? Arduino

Workaround

Add the following to my yarn config:

"resolutions": {
  "@serialport/bindings": "2.0.2"
}
@reconbot
Copy link
Member

reconbot commented Jan 3, 2019

Duplicate of #1751. We'll either pull the release or release an update.

@reconbot reconbot closed this as completed Jan 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants