Make GuildChannel::send_message work in threads #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the cache feature is enabled, GuildChannel::send_message invokes utils::user_has_perms which tries to look up the thread in the channels cache, fails and throws a model::Error::ChannelNotFound. send_message lazily propagates any error, so the cache miss brings down the whole send_message invocation.
arqunis
added
fix
arqunis
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the cache feature is enabled,
GuildChannel::send_messageinvokesutils::user_has_permswhich tries to look up the thread in the channels cache. Threads are often not in cache, so it fails and throws amodel::Error::ChannelNotFound.send_messagelazily propagates any error, so the cache miss brings down the whole send_message invocation.This PR fixes
send_messageto not abort the invocation if the sanity check throws an error.