Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should deserialize_any be avoided in a library? #2726

Closed
pitdicker opened this issue Apr 6, 2024 · 0 comments
Closed

Should deserialize_any be avoided in a library? #2726

pitdicker opened this issue Apr 6, 2024 · 0 comments

Comments

@pitdicker
Copy link

pitdicker commented Apr 6, 2024 •
edited

Asking this for chronotope/chrono#926.

In chrono we have custom (de)serialization modules that serialize a DateTime to/from a i64 timestamp. There is a request for deserializing timestamps encoded as strings as well. Is using deserialize_any as in that PR the right choice? Or would that be a breaking change for users of formats that are not self-describing?

If it is not the right choice, can I ask for a quick opinion on implementing a host of modules for string timestamps (chronotope/chrono#1067)?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pitdicker