Implement `#[key = ...]` #2698

jun-sheaf · 2024-02-13T02:20:02Z

This PR implements the ability to use a limited set of literals for keys when serializing and deserializing structs. The motivation is written in #2695.

Closes #2695

Limitations

We purposefully error for string keys since this is already supported using rename.
Floats are not supported (Rust doesn't support them for match statements and in practice, this is not done).
Negative keys are not supported for the time being.
Keys can clash if the user wants to. (Footgun?)

juntyr · 2024-03-09T07:10:11Z

serde/src/ser/mod.rs

+    {
+        let _ = key;
+        let _ = value;
+        Ok(())


Shouldn't the default implementation error instead of silently doing nothing?

Implement #[key = ...]

159e55d

jun-sheaf mentioned this pull request Feb 14, 2024

Implement #[key = ...] #2700

Open

juntyr reviewed Mar 9, 2024

View reviewed changes

serde/src/ser/mod.rs

{

let _ = key;

let _ = value;

Ok(())

Copy link

juntyr Mar 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the default implementation error instead of silently doing nothing?

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement `#[key = ...]` #2698

Implement `#[key = ...]` #2698

jun-sheaf commented Feb 13, 2024 •

edited

juntyr Mar 9, 2024

Implement #[key = ...] #2698

Are you sure you want to change the base?

Implement #[key = ...] #2698

Conversation

jun-sheaf commented Feb 13, 2024 • edited

Limitations

juntyr Mar 9, 2024

Choose a reason for hiding this comment

Implement `#[key = ...]` #2698

Implement `#[key = ...]` #2698

jun-sheaf commented Feb 13, 2024 •

edited