Fix generation of non-existent lifetime 'de when enum contains a #[serde(flatten)] field and a 'static reference
#2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rde(flatten)] field and a 'static reference
This function is called for untagged, internally and externally tagged enums, but `deserializer` parameter is `None` only for the latest. Only when it's `None` `DeserializeSeed` impl is used
Mingun
force-pushed
the
fix-flatten+static
branch
from
c7110a8
to
38c130a
Compare
crapStone
added a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Mar 15, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [serde](https://serde.rs) ([source](https://github.com/serde-rs/serde)) | dependencies | patch | `1.0.152` -> `1.0.156` | --- ### Release Notes <details> <summary>serde-rs/serde</summary> ### [`v1.0.156`](https://github.com/serde-rs/serde/releases/tag/v1.0.156) [Compare Source](serde-rs/serde@v1.0.155...v1.0.156) - Documentation improvements ### [`v1.0.155`](https://github.com/serde-rs/serde/releases/tag/v1.0.155) [Compare Source](serde-rs/serde@v1.0.154...v1.0.155) - Support `Serialize` and `Deserialize` impls for `core::ffi::CStr` and `alloc::ffi::CString` without "std" feature ([#​2374](serde-rs/serde#2374), thanks [@​safarir](https://github.com/safarir)) ### [`v1.0.154`](https://github.com/serde-rs/serde/releases/tag/v1.0.154) [Compare Source](serde-rs/serde@v1.0.153...v1.0.154) - Fix "undeclared lifetime" error in generated code when deriving Deserialize for an enum with both `flatten` and `'static` fields ([#​2383](serde-rs/serde#2383), thanks [@​Mingun](https://github.com/Mingun)) ### [`v1.0.153`](https://github.com/serde-rs/serde/releases/tag/v1.0.153) [Compare Source](serde-rs/serde@v1.0.152...v1.0.153) - Support `serde(alias = "…")` attribute used inside of flattened struct ([#​2387](serde-rs/serde#2387), thanks [@​bebecue](https://github.com/bebecue)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTcuMSIsInVwZGF0ZWRJblZlciI6IjM1LjIuMyJ9--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Co-authored-by: crapStone <crapstone01@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1812 Reviewed-by: crapStone <crapstone@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
test_gentests prevents future regressions.Fixes #2371.