Enable 128-bit integers on emscripten post Rust 1.40 #2076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
changed the title
|
Thanks! @dtolnay would it be possible to get a point release for this? In practice most of the ecosystem does not pref-gate Serializer/Deserializer impls on emscripten; so the status quo is effectively that programs that use serde just don't compile on emscripten; I'd like to get that fixed. |
|
Published in 1.0.128. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-lang/rust#65251 fixed the issue where Rust was unable to support 128-bit integers on emscripten targets, that has been in Rust since 1.40 (looking at the tags on rust-lang/rust@2bf59be)
Fixes #1995, supersedes #2049