Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deserialize adjacently tagged newtype variants with optional content as None instead of erroring when content field is missing #1706

Merged
merged 2 commits into from May 10, 2020
Merged

Deserialize adjacently tagged newtype variants with optional content as None instead of erroring when content field is missing #1706

merged 2 commits into from May 10, 2020

Conversation

yhtez
Copy link
Contributor

@yhtez yhtez commented Jan 6, 2020

Fixes #1553

@yhtez yhtez marked this pull request as draft May 6, 2020 16:19
@yhtez yhtez marked this pull request as ready for review May 6, 2020 16:19
dtolnay
dtolnay approved these changes May 10, 2020
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit 172edc4 into serde-rs:master May 10, 2020
@dtolnay
Copy link
Member

dtolnay commented May 10, 2020

Published in 1.0.109.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optional content for enum variants?
2 participants
@yhtez @dtolnay