Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update proc_macro2, quote, and syn to v1.0 #1601

Closed
nbraud opened this issue Aug 14, 2019 · 2 comments
Closed

Please update proc_macro2, quote, and syn to v1.0 #1601

nbraud opened this issue Aug 14, 2019 · 2 comments

Comments

@nbraud
Copy link

nbraud commented Aug 14, 2019

Dear serde maintainers,

While packaging the newest versions of proc-macro2, quote, and syn in Debian (which all recently reached 1.0), I discovered that serde doesn't yet support those version.

I am attempting to make a patch for this, but there's a lot to fix, so help would be appreciated.

@dtolnay
Copy link
Member

dtolnay commented Aug 14, 2019

For now you may be able to cherrypick #1591, if that's an option for you.

@nbraud
Copy link
Author

nbraud commented Aug 15, 2019

Thanks @dtolnay, I had missed that PR (probably only searched through open issues)

I ended up picking all the commits (except the rust-format one) since v1.0.98, since it didn't seem worth trying to backport only the necessary change. Ran into some unrelated issues, but I can hopefully fix serde_derive in Debian tomorrow :)

@nbraud nbraud closed this as completed Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants