-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for atomics data types? #1496
Comments
I would prefer to match Debug which uses Ordering::SeqCst. I would be prepared to consider a PR adding impls that use SeqCst. |
SeqCst is the strongest guarantee possible. This is ok and maybe even desiderable in debugging code, but I am not sure is desiderable on production code. What is your take on this? Do you believe performance won't be a concern? I am not sure of the performance characteristics of serde (never used) so I am really asking a little more feedback on your thoughts! Cheers |
If someone observes serialization of atomics as a bottleneck, they can use a |
I am not sure if I got the time to do this anyway, I don't believe in the next few weeks at the very least. If anybody wants to jump on it feel free to just implement it! |
I believe #1572 solves this (and is ready for review). |
Hi,
it seems like there is no Serialize support for atomic data type: https://doc.rust-lang.org/core/sync/atomic/index.html
Is there any reason for this?
A first implementation would be to simply load them using
Ordering::Relaxed
and that should be quite enough.The text was updated successfully, but these errors were encountered: