Make Value be From<Option<T>>

[kvnvelasco]

Adds an implementation for From<Option<T>> for all T where T: Into<Value>

Use case: Ergonomics for manually constructing values for insertion into BTreeMap (sentry does this)

I have no idea where / how the tests happen. If this is an acceptable change, could someone point me in the direction of the tests?

[dtolnay]

Could you share how this would improve sentry's use case? What would they be writing without and with this impl?

[kvnvelasco]

So sentry has a context type you can attach to errors BTreeMap<String, Value>.

Almost every instance where context needs to be added to a sentry event, the value is derived from other pieces of state. Most of the time they are Option<T>

where

let user_meta: Option<String> = None;

context.insert(
  "user_meta".into(), 
   match user_meta { 
      Some(u) => u.into(),
      None => Value::Null
   }
)

Is a pretty common expression. We don't really want to have to bring in a macro everywhere (because there are probably hundreds of these).

All other non option types we send take advantage of the From implementations.

With the impl it'd be

context.insert(
  "user_meta".into(), 
   user_meta.into()
)

Also as opposed to

context.insert(
  "user_meta".into(), 
   to_value(user_meta).unwrap()
)

Also, not (at) sentry. My bad. I meant when using sentry.

[dtolnay]

Thank you for the clarification. This looks good to me.