use from_utf8_unchecked in the fmt::Display implementation of Value #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`WriterFormatter` has been moved into it's own little module to enforce using it's `new` method to convey the unsafe requirements. the safety requirements that the serializer only emits valid utf8 is already assumed by the existing `to_string` methods. this speeds up formatting large `Value`s by about 33% in my testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the serializer only emits valid utf8 by default we can remove the checks that the data being formatted is valid.
WriterFormatterhas been moved into it's own little module to enforce using it'snewmethod to convey the unsafe requirements.the safety requirements that the serializer only emits valid utf8 is already assumed by the existing
to_stringmethods.Marking
WriterFormatteras unsafe is not strictly necesarry as it is already contained within the module bounds, but this way it's a bit more explicit about the assumptions being made.this speeds up formatting large
Values by about 33% in my testing.