Add Read implementation for &mut Read #684
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Read implementation for &mut Read. Because of the
Sealed
trait, we can't implementRead
in other create.This kind of trick is required if we want to build a streaming implementation (like asked in #526, #665) in another crate :
We can't use
serde_json::Deserializer
because we need to give it the Read object the streaming deserializer is working with and there is no way to get it back.