Implement Eq for Map, Number and Value. #640
Merged
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtolnay
requested changes
Mar 27, 2020
There was a problem hiding this comment.
Could you check why the build is failing? https://travis-ci.org/github/serde-rs/json/jobs/667909263
These types already have `PartialEq` implementations which define equivalence relations, so we can implement `Eq` as well. Fixes serde-rs#638.
smarnach
force-pushed
the
smarnach/eq-impls
branch
from
ba23ee9 to
99eb4ea
Compare
|
I failed to test locally with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These types already have
PartialEqimplementations which define equivalence relations, so we can implementEqas well. Fixes #638.