Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Required Minimum indexmap Version #590

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Fix Required Minimum indexmap Version #590

merged 1 commit into from
Dec 4, 2019

Conversation

nlordell
Copy link
Contributor

@nlordell nlordell commented Dec 4, 2019 •
edited

The preserve-order feature uses indexmap::map::OccupiedEntry::swap_remove method which was only added in 1.2, however, the Cargo.toml incorrectly requires ^1.0.

@nlordell nlordell changed the title fix required minimum indexmap version Fix Required Minimum indexmap Version Dec 4, 2019
@nlordell nlordell mentioned this pull request Dec 4, 2019
Merged
dtolnay
dtolnay approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit 76b2366 into serde-rs:master Dec 4, 2019
@dtolnay
Copy link
Member

dtolnay commented Dec 4, 2019

Published in 1.0.43.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nlordell @dtolnay