Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the various PartialEq<Value> impls for primitives #380

Closed
dtolnay opened this issue Nov 8, 2017 · 1 comment
Closed

Remove the various PartialEq<Value> impls for primitives #380

dtolnay opened this issue Nov 8, 2017 · 1 comment
Labels
wishlist for 2.0

Comments

@dtolnay
Copy link
Member

dtolnay commented Nov 8, 2017

Currently we have:

  • impl PartialEq<Value> for str
  • impl PartialEq<Value> for &'a str
  • impl PartialEq<Value> for String
  • impl PartialEq<Value> for i64
  • impl PartialEq<Value> for u64
  • impl PartialEq<Value> for f64
  • impl PartialEq<Value> for bool

These lead to surprising inference errors in code that is unrelated to Serde. One example is #357.
@dtolnay dtolnay closed this as completed Nov 8, 2017
@dtolnay
Copy link
Member Author

dtolnay commented Nov 26, 2017

Also encountered in rust-lang/rust#46257.

@dtolnay dtolnay mentioned this issue Nov 26, 2017
Open
@serde-rs serde-rs locked and limited conversation to collaborators Jul 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
wishlist for 2.0
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dtolnay