From ec20407ba874b7bc7fd0b313208d2e443452d254 Mon Sep 17 00:00:00 2001 From: Kazuhiro Sera Date: Fri, 28 May 2021 19:34:26 +0900 Subject: [PATCH] Fix #1025 websocket_client based SocketModeClient may fail in on_close callback --- slack_sdk/socket_mode/websocket_client/__init__.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/slack_sdk/socket_mode/websocket_client/__init__.py b/slack_sdk/socket_mode/websocket_client/__init__.py index 992ba625f..95fd07da0 100644 --- a/slack_sdk/socket_mode/websocket_client/__init__.py +++ b/slack_sdk/socket_mode/websocket_client/__init__.py @@ -167,9 +167,15 @@ def on_error(ws: WebSocketApp, error: Exception): for listener in self.on_error_listeners: listener(ws, error) - def on_close(ws: WebSocketApp): + def on_close( + ws: WebSocketApp, + close_status_code: Optional[int] = None, + close_msg: Optional[str] = None, + ): if self.logger.level <= logging.DEBUG: - self.logger.debug("on_close invoked") + self.logger.debug( + f"on_close invoked: (code: {close_status_code}, message: {close_msg})" + ) if self.auto_reconnect_enabled: self.logger.info("Received CLOSE event. Going to reconnect...") self.connect_to_new_endpoint()