Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rawAttributes deprecated but still used in Typescript docs (docs) (v7) #352

Open
1 of 4 tasks
mschipperheyn opened this issue Nov 21, 2022 · 1 comment
Open
1 of 4 tasks

Comments

@mschipperheyn
Copy link

Issue Creation Checklist

  • [x ] I understand that my issue will be automatically closed if I don't fill in the requested information
  • [ x] I have read the contribution guidelines

Bug Description

I noticed that the documentation for v7 still uses the static rawAttributes method instead of getAttributes. rawAttributes is deprecated.

Reproducible Example

as of alpha-19

Here is the link to the SSCCE for this issue:

https://sequelize.org/docs/v7/other-topics/typescript/

What do you expect to happen?

The examples should use non deprecated code.

What is actually happening?

It uses deprecated code

Environment

  • Sequelize version: v7.0.0-alpha.19
  • Node.js version: v16
  • If TypeScript related: TypeScript version: v4.8
  • Database & Version: mysql 5.7
  • Connector library & Version: msql2

Would you be willing to resolve this issue by submitting a Pull Request?

  • Yes, I have the time and I know how to start.
  • Yes, I have the time but I will need guidance.
  • No, I don't have the time, but my company or I are supporting Sequelize through donations on OpenCollective.
  • No, I don't have the time, and I understand that I will need to wait until someone from the community or maintainers is interested in resolving my issue.

Indicate your interest in the resolution of this issue by adding the 👍 reaction. Comments such as "+1" will be removed.

@WikiRik WikiRik transferred this issue from sequelize/sequelize Nov 21, 2022
@WikiRik
Copy link
Member

WikiRik commented Nov 21, 2022

I've transferred this to our docs repo, but it's certainly a valid report. We'll look into it!

@ephys ephys removed the type: docs label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants