Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Cloudflare D1 Connections #17236

Open
4 of 8 tasks
talltyler opened this issue Apr 2, 2024 · 1 comment
Open
4 of 8 tasks

Support Cloudflare D1 Connections #17236

talltyler opened this issue Apr 2, 2024 · 1 comment
Labels
dialect: new For issues and PRs that relate to new dialect support dialect: sqlite For issues and PRs. Things that involve SQLite (and do not involve all dialects). type: feature For issues and PRs. For new features. Never breaking changes.

Comments

@talltyler
Copy link

Issue Creation Checklist

  • I understand that my issue will be automatically closed if I don't fill in the requested information
  • I have read the contribution guidelines

Feature Description

Enable the ability to connect to a Cloudflare D1 sqlite database like these other ORMs.

Describe the feature you'd like to see implemented

I would like to be able to configure a connection to a Cloudflare D1 sqlite database and utilize Sequelize as an ORM rather than these other ORMs they are currently suggesting. Because the setup isn't actually a remote or even file based connection maybe this could be enabled with something as simple as const sequelize = new Sequelize('sqlite::d1:') but I'm totally open to other options as long as it unlocks the ability for it to be used.

Describe why you would like this feature to be added to Sequelize

I'm trying to build a project on Cloudflare workers with D1 as its database and without support for connecting to this I'll need to use a different ORM. I first started using Sequelize maybe a decade ago and there are features that it has that work well that some of these newer ORMs don't. The stability and straightforward simplicity of Sequelize makes sense to me and I would like to continue using it if I can.

Is this feature dialect-specific?

  • No. This feature is relevant to Sequelize as a whole.
  • Yes. This feature only applies to the following dialect(s): sqlite

Would you be willing to resolve this issue by submitting a Pull Request?

  • Yes, I have the time and I know how to start.
  • Yes, I have the time but I will need guidance.
  • No, I don't have the time, but my company or I are supporting Sequelize through donations on OpenCollective.
  • No, I don't have the time, and I understand that I will need to wait until someone from the community or maintainers is interested in implementing my feature.

Indicate your interest in the addition of this feature by adding the 👍 reaction. Comments such as "+1" will be removed.

@talltyler talltyler added pending-approval Bug reports that have not been verified yet, or feature requests that have not been accepted yet type: feature For issues and PRs. For new features. Never breaking changes. labels Apr 2, 2024
@ephys ephys added dialect: new For issues and PRs that relate to new dialect support dialect: sqlite For issues and PRs. Things that involve SQLite (and do not involve all dialects). and removed pending-approval Bug reports that have not been verified yet, or feature requests that have not been accepted yet labels Apr 2, 2024
@ephys
Copy link
Member

ephys commented Apr 2, 2024

From what I can see, it seems we can run D1 databases locally. From looking at other ORMs with D1 support, there does not seem to be a lot of changes required to support D1 either (though that may not be the case for all of the features we support)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialect: new For issues and PRs that relate to new dialect support dialect: sqlite For issues and PRs. Things that involve SQLite (and do not involve all dialects). type: feature For issues and PRs. For new features. Never breaking changes.
Projects
None yet
Development

No branches or pull requests

2 participants