Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateOptions is missing plain property #16969

Open
3 tasks
seanh169 opened this issue Jan 16, 2024 · 1 comment
Open
3 tasks

UpdateOptions is missing plain property #16969

seanh169 opened this issue Jan 16, 2024 · 1 comment
Labels
pending-approval Bug reports that have not been verified yet, or feature requests that have not been accepted yet type: bug

Comments

@seanh169
Copy link

seanh169 commented Jan 16, 2024

Issue Creation Checklist

  • [ x] I understand that my issue will be automatically closed if I don't fill in the requested information
  • [ x] I have read the contribution guidelines

Bug Description

Attempting to update an entity, the UpdateOptions type does not include the plain option.

Reproducible Example

const updatedUser = await User.update( { name: 'Joe' }, { where: { id: 1 }, returning: true, plain: true } )

Here is the link to the SSCCE for this issue:

What do you expect to happen?

I expect to see plain on the type of UpdateOptions found here ->
(https://github.com/sequelize/sequelize/blob/main/packages/core/src/model.d.ts#L1244)

What is actually happening?

I am receiving this TS error ->

Screenshot 2024-01-16 at 8 43 06 AM

Environment

  • Sequelize version: 6.35.2
  • Node.js version: 16.13.0
  • If TypeScript related: TypeScript version: 5.3.3
  • Database & Version: MSSQL
  • Connector library & Version: tedious

Would you be willing to resolve this issue by submitting a Pull Request?

  • Yes, I have the time and I know how to start.
  • [x ] Yes, I have the time but I will need guidance.
  • No, I don't have the time, but my company or I are supporting Sequelize through donations on OpenCollective.
  • No, I don't have the time, and I understand that I will need to wait until someone from the community or maintainers is interested in resolving my issue.

Indicate your interest in the resolution of this issue by adding the 👍 reaction. Comments such as "+1" will be removed.

@seanh169 seanh169 added pending-approval Bug reports that have not been verified yet, or feature requests that have not been accepted yet type: bug labels Jan 16, 2024
@ephys
Copy link
Member

ephys commented Mar 26, 2024

What is the goal of using the plain option here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-approval Bug reports that have not been verified yet, or feature requests that have not been accepted yet type: bug
Projects
None yet
Development

No branches or pull requests

2 participants