fix(oracle): remove hardcoded maxRows value #15323
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description Of Change
The Oracle dialect had the maxRows value hardcoded to 1000 so select queries returned only the first 1000 rows unless the user set the maxRows option. Fixing this would fetch all the rows from the table instead.
Fix to the issue raised in https://stackoverflow.com/questions/74357044/sequelize-have-a-limit-of-return-1000-rows-of-my-table-oracle-connection