Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove options.model overwrite on bulkUpdate #15252

Merged
merged 2 commits into from Nov 7, 2022
Merged

fix: remove options.model overwrite on bulkUpdate #15252

merged 2 commits into from Nov 7, 2022

Conversation

BigsonLvrocha
Copy link
Contributor

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

This is the same changes from pr #15231

BigsonLvrocha and others added 2 commits November 7, 2022 17:22
@BigsonLvrocha
fix: remove options.model overwrite on bulkUpdate (#15231)
0db1273 
* fix: remove options.model overwrite on bulkUpdate

* fix: fix typo in test

* fix: make test simpler

Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>

Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
(cherry picked from commit c620469)
@BigsonLvrocha
fix: adapt test to v6
891d528
@BigsonLvrocha
Copy link
Contributor Author

BigsonLvrocha commented Nov 7, 2022 •
edited

I noticed some tests have failed, but I don't know how to fix them, some appears to be flacky, but I have no idea why https://github.com/sequelize/sequelize/actions/runs/3413855893/jobs/5681066691 and https://github.com/sequelize/sequelize/actions/runs/3413855893/jobs/5681066816 were affected, are they flacky too? how can I restart the tests?

@WikiRik
Copy link
Member

WikiRik commented Nov 7, 2022

Those are indeed flaky. I'll restart the tests

WikiRik
WikiRik approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good, thanks!

@WikiRik WikiRik merged commit 67e69cd into sequelize:v6 Nov 7, 2022
@BigsonLvrocha BigsonLvrocha deleted the fix-bulk-update-model-mapping branch November 7, 2022 21:35
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

🎉 This PR is included in version 6.25.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WikiRik WikiRik WikiRik approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BigsonLvrocha @WikiRik