Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): add instance.dataValues property to model.d.ts #15240

Merged
merged 1 commit into from Nov 5, 2022
Merged

fix(types): add instance.dataValues property to model.d.ts #15240

merged 1 commit into from Nov 5, 2022

Conversation

spearmootz
Copy link
Contributor

@spearmootz spearmootz commented Nov 5, 2022 •
edited

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

same as this PR but on v6
#15208

Todos

This was referenced Nov 5, 2022
Closed
Merged
@fzn0x fzn0x changed the title Update model.d.ts fix(types): add instance.dataValues property to model.d.ts Nov 5, 2022
fzn0x
fzn0x approved these changes Nov 5, 2022
View reviewed changes
Copy link
Member

@fzn0x fzn0x left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Also thanks for migrating a test to typescript in v7, that is really reduce our weight and you know it :)

@fzn0x fzn0x added the type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense. label Nov 5, 2022
@fzn0x fzn0x merged commit 00c6da3 into sequelize:v6 Nov 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2022

🎉 This PR is included in version 6.25.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzn0x fzn0x fzn0x approved these changes

Assignees
No one assigned
Labels
released type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spearmootz @fzn0x