fix: remove options.model overwrite on bulkUpdate #15231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigsonLvrocha
changed the title
ephys
previously requested changes
Nov 5, 2022
WikiRik
reviewed
Nov 7, 2022
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
BigsonLvrocha
requested review from
WikiRik and
ephys
and removed request for
ephys and
WikiRik
|
sorry for the span on request, I did not know only one review was requested per pr |
WikiRik
approved these changes
Nov 7, 2022
|
Thanks for this PR! |
|
@WikiRik |
|
Good question! Just open a PR just like this one, but into the |
5 tasks
WikiRik
pushed a commit
that referenced
this pull request
Nov 7, 2022
* fix: remove options.model overwrite on bulkUpdate (#15231) * fix: remove options.model overwrite on bulkUpdate * fix: fix typo in test * fix: make test simpler Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com> Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com> (cherry picked from commit c620469) * fix: adapt test to v6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description Of Change
Closes #11364
This is a way that keeps the current behaviour of bulkUpdate while fixing the unexpected behaviour when calling
.updatewhen there are 2 or more models defined for the same tableTodos