Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): fix TS 4.9 excessive depth error on InferAttributes (v6) #15135

Merged
merged 2 commits into from Oct 15, 2022

Conversation

ephys
Copy link
Member

@ephys ephys commented Oct 15, 2022

This is the same PR as #15134, but for v6

Closes #15133

@ephys ephys changed the base branch from main to v6 October 15, 2022 18:38
@ephys ephys self-assigned this Oct 15, 2022
@ephys ephys added type: bug type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense. labels Oct 15, 2022
@ephys ephys marked this pull request as draft October 15, 2022 18:43
@ephys ephys marked this pull request as ready for review October 15, 2022 19:10
@WikiRik
Copy link
Member

WikiRik commented Oct 15, 2022

The other changes from main are not needed here?

@ephys
Copy link
Member Author

ephys commented Oct 15, 2022

No, they're not written in TypeScript in v6

@ephys ephys merged commit 851daaf into v6 Oct 15, 2022
@ephys ephys deleted the ephys/fix-ts-4.9-v6 branch October 15, 2022 19:52
@github-actions
Copy link
Contributor

🎉 This PR is included in version 6.25.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released type: bug type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants