New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(oracle): added support for connectString #15042
Conversation
* feat: added support for connectString Co-authored-by: Hasan Jamil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an integration test you can add for this?
Co-authored-by: Hasan Jamil
@hjamil-24 @ephys where is this PR at ? :) I've been waiting on this before doing some social media stuff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last change request is small, once it's done I think this is good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work :)
Thanks everyone. |
Co-authored-by: Hasan Jamil
Pull Request Checklist
Description Of Change
This is a feature addition for Oracle Database to allow Sequelize constructor to use connectString for authentication.
The additional way to authenticate by this change is as follow:
const sequelize = new Sequelize({dialect: 'oracle', username: 'demouser', password: 'password', dialectOptions: {connectString: 'orcl1'}});
The link to docs PR: sequelize/website#266