Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oracle): added support for connectString #15042

Merged
merged 6 commits into from Oct 11, 2022
Merged

feat(oracle): added support for connectString #15042

merged 6 commits into from Oct 11, 2022

Conversation

hjamil-24
Copy link

  • feat: added support for connectString
    Co-authored-by: Hasan Jamil

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

This is a feature addition for Oracle Database to allow Sequelize constructor to use connectString for authentication.
The additional way to authenticate by this change is as follow:

const sequelize = new Sequelize({dialect: 'oracle', username: 'demouser', password: 'password', dialectOptions: {connectString: 'orcl1'}});

The link to docs PR: sequelize/website#266

* feat: added support for connectString
Co-authored-by: Hasan Jamil
cjbj
cjbj previously approved these changes Sep 27, 2022
Copy link
Member

@ephys ephys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an integration test you can add for this?

src/dialects/oracle/connection-manager.js Show resolved Hide resolved
@cjbj
Copy link

cjbj commented Oct 10, 2022

@hjamil-24 @ephys where is this PR at ? :) I've been waiting on this before doing some social media stuff.

Copy link
Member

@ephys ephys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last change request is small, once it's done I think this is good to go!

src/dialects/oracle/connection-manager.js Show resolved Hide resolved
Copy link
Member

@ephys ephys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work :)

@ephys ephys merged commit 06ad05d into sequelize:v6 Oct 11, 2022
@cjbj
Copy link

cjbj commented Oct 11, 2022

Thanks everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants