fix(types): missing type for oracle dialect in v6 #14991
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzn0x
added
the
type: typescript
|
This changes targets v6 only since Oracle DB dialect was only in v6 branch. |
sdepold
approved these changes
Sep 16, 2022
|
👍 |
|
Please don't merge before answering this: Will the commit message cause a patch or a minor version bump? We should aim for the patch |
I'm agree with the patch option 👍 |
|
I think you need to change your commit message to fix instead of feat for that |
fzn0x
changed the title
Changed, is there anything required for the patch? |
|
Can you rename the commit message too? |
Looks like the branch does not allow rebase, maybe I will create another PR. |
WikiRik
pushed a commit
that referenced
this pull request
Sep 16, 2022
Target patch releases of #14991
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same as #14137
This is causing casting with any, just notice it when try the oracle DB.
Closes none but this is to prevent the future issues