Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: update retry-as-promised #14966

Merged
merged 1 commit into from Sep 8, 2022
Merged

meta: update retry-as-promised #14966

merged 1 commit into from Sep 8, 2022

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Sep 8, 2022

Pull Request Checklist

Please make sure to review and check all of these items:

  • Have you added new tests to prevent regressions?
  • Does yarn test or yarn test-DIALECT pass with this change (including linting)?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description Of Change

Fixes #14952
The breaking change in v6 of retry-as-promised should not affect sequelize.

@WikiRik WikiRik requested a review from fzn0x September 8, 2022 12:57
@WikiRik WikiRik self-assigned this Sep 8, 2022
sdepold
sdepold approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@sdepold sdepold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surprised to see that it is just green :)

@WikiRik WikiRik merged commit e3a5279 into v6 Sep 8, 2022
@WikiRik WikiRik deleted the WikiRik/update-retry-as-promised-v6 branch September 8, 2022 15:21
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

🎉 This PR is included in version 6.21.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdepold sdepold sdepold approved these changes

@fzn0x fzn0x Awaiting requested review from fzn0x

Assignees

@WikiRik WikiRik

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WikiRik @sdepold