Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): backport #14704 for v6 #14964

Merged
merged 3 commits into from Sep 9, 2022
Merged

fix(types): backport #14704 for v6 #14964

merged 3 commits into from Sep 9, 2022

Conversation

fzn0x
Copy link
Member

@fzn0x fzn0x commented Sep 7, 2022 •
edited

Pull Request Checklist

Please make sure to review and check all of these items:

  • Have you added new tests to prevent regressions?
  • Does yarn test or yarn test-DIALECT pass with this change (including linting)?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description Of Change

Close #14957

@fzn0x fzn0x added the type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense. label Sep 7, 2022
@fzn0x fzn0x self-assigned this Sep 7, 2022
@fzn0x fzn0x linked an issue Sep 7, 2022 that may be closed by this pull request
Bad typings for (static) Model.increment and Model.decrement #14957
Closed
4 tasks
@WikiRik WikiRik merged commit 33d94b2 into v6 Sep 9, 2022
@WikiRik WikiRik deleted the increment-decrement-typings branch September 9, 2022 01:34
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

🎉 This PR is included in version 6.21.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WikiRik WikiRik WikiRik approved these changes

@sdepold sdepold Awaiting requested review from sdepold

Assignees

@fzn0x fzn0x

Labels
released type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad typings for (static) Model.increment and Model.decrement
3 participants
@fzn0x @WikiRik @sdepold