Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github-actions bot keeps commenting 'stale' instead of actually closing. #14833

Closed
3 of 6 tasks
laurelgr opened this issue Aug 4, 2022 · 3 comments
Closed
3 of 6 tasks
Assignees
Labels
type: other For issues and PRs. Something that does not fit in any of the other "type:" labels.

Comments

@laurelgr
Copy link

laurelgr commented Aug 4, 2022

Issue Creation Checklist

  • I understand that my issue will be automatically closed if I don't fill in the requested information
  • I have read the contribution guidelines

Bug Description

The github-actions bot removes then re-add the stale label on a stale issue instead of closing said issue.

Reproducible Example

Leave an issue stale for more than 14 days and watch the bot come back to not close it.
Current examples: issue 14588, issue 14600

What do you expect to happen?

Bot closes issue instead of keeping it open and restarting the stale counter.
Or bot does nothing instead of repeatedly commenting...

I don't have anything against stale issues in specific, but the repeat comments of the bots make the older issues seem more commented than they truly are, and this seems quite unhelpful. Also, I believe maintainers have other things to do than clean up after the bot supposed to do its job. Previous stale bot managed to close issues, from what I saw in older issues.

What is actually happening?

Bot remove the stale label, possibly triggering a reset on the label counter.

Environment

Issues section of sequelize/sequelize repository on github 😇

Would you be willing to resolve this issue by submitting a Pull Request?

  • Yes, I have the time and I know how to start.
  • Yes, I have the time but I will need guidance.
  • No, I don't have the time, but my company or I are supporting Sequelize through donations on OpenCollective.
  • No, I don't have the time, and I understand that I will need to wait until someone from the community or maintainers is interested in resolving my issue.

Indicate your interest in the resolution of this issue by adding the 👍 reaction. Comments such as "+1" will be removed.

@WikiRik
Copy link
Member

WikiRik commented Aug 10, 2022

Thanks for bringing this to our attention. I already thought there was something strange with this, although we haven't changed anything to the config of the GitHub actions for this.
Probably because we use actions/stale@main we've missed an update. I'll look into this

@WikiRik WikiRik self-assigned this Aug 10, 2022
@WikiRik WikiRik added type: bug type: other For issues and PRs. Something that does not fit in any of the other "type:" labels. and removed type: bug labels Aug 10, 2022
@WikiRik
Copy link
Member

WikiRik commented Aug 10, 2022

Might be related to actions/stale#775 btw

@ephys
Copy link
Member

ephys commented Sep 17, 2022

Looks like they fixed it

@ephys ephys closed this as completed Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: other For issues and PRs. Something that does not fit in any of the other "type:" labels.
Projects
None yet
Development

No branches or pull requests

3 participants