Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): align the return value of increment and decrement with actual behavior #14704

Merged
merged 10 commits into from Jul 8, 2022
Merged

fix(types): align the return value of increment and decrement with actual behavior #14704

merged 10 commits into from Jul 8, 2022

Conversation

fzn0x
Copy link
Member

@fzn0x fzn0x commented Jun 30, 2022 •
edited by ephys

Pull Request Checklist

Please make sure to review and check all of these items:

  • Have you added new tests to prevent regressions?
  • Does yarn test or yarn test-DIALECT pass with this change (including linting)?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description Of Change

Closes #14695
Closes #14145

Todos

  • Add typings which increment function related

@fzn0x fzn0x added the type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense. label Jun 30, 2022
@fzn0x fzn0x closed this Jun 30, 2022
@fzn0x fzn0x force-pushed the increment-related-typings branch from ce07c3a to 37859a6 Compare June 30, 2022 23:01
@fzn0x fzn0x reopened this Jun 30, 2022
@fzn0x fzn0x self-assigned this Jun 30, 2022
ephys
ephys requested changes Jul 3, 2022
View reviewed changes
Copy link
Member

@ephys ephys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I've taken the liberty of marking that other PR as closed by this one too, since it does the same thing: https://github.com/sequelize/sequelize/pull/14145/files

Can I ask you to copy over the tests that were added in that PR? As well as adding the affectedCount second return value

@fzn0x fzn0x changed the title fix(typings): returns same value from increment and decrement function fix(types): returns same value from increment and decrement function Jul 5, 2022
@fzn0x
Copy link
Member Author

fzn0x commented Jul 5, 2022

Thanks for the PR!

I've taken the liberty of marking that other PR as closed by this one too, since it does the same thing: https://github.com/sequelize/sequelize/pull/14145/files

Can I ask you to copy over the tests that were added in that PR? As well as adding the affectedCount second return value

Sure! Added, thanks for letting know about the PR :)

ephys
ephys approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@ephys ephys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you for getting this done ✨

@ephys ephys changed the title fix(types): returns same value from increment and decrement function fix(types): align the return value of increment and decrement with actual behavior Jul 8, 2022
@ephys ephys merged commit 89dd2ec into main Jul 8, 2022
@ephys ephys deleted the increment-related-typings branch July 8, 2022 13:24
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2022

🎉 This PR is included in version 7.0.0-alpha.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

fzn0x added a commit that referenced this pull request Sep 7, 2022
@fzn0x
fix(types): backport of #14704 for v6
e0d2a8d
WikiRik pushed a commit that referenced this pull request Sep 9, 2022
@fzn0x @sdepold
fix(types): backport #14704 for v6 (#14964)
33d94b2 
* fix(types): backport of #14704 for v6

* test: increment and decrement function

Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ephys ephys ephys approved these changes

Assignees

@fzn0x fzn0x

Labels
released on @v7 type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong return of typing in increment function
2 participants
@fzn0x @ephys