feat(oracle): add oracle dialect support #14638

sudarshan12s · 2022-06-14T10:06:03Z

feat(oracle): add oracle dialect support

Pull Request Checklist

Please make sure to review and check all of these items:

Have you added new tests to prevent regressions?
Does yarn test or yarn test-DIALECT pass with this change (including linting)?
Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
Did you update the typescript typings accordingly (if applicable)?
Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description Of Change

Adding Oracle dialect support to Sequelize. Integration and Unit tests have been run on the new dialect. A yaml file for automating tests is included in the PR. The Github workflow up to the point of Oracle software installation has been verified.

We acknowledge and thank contributors to previous Oracle support efforts. Significant improvements have been made over these PRs:

Sequelize documentation changes are done in a separate PR at sequelize/website#187

This PR is for the V6 branch, which is in wide use. We will work on V7 once this V6 MR is OK'd by the community.

Minimum Supported version of dependency

Node-oracledb 5.4.0
Oracle Database 18.4

Todos

* feat(oracle): add oracle dialect support

ephys

Overall really good work.
I have many notes due to the sheer size of the PR, but this is impressive :)

ephys · 2022-06-19T09:31:00Z

.github/workflows/ci.yml

+    strategy:
+      fail-fast: false
+      matrix:
+        node-version: [10, 16]


You can bump it to 18 now, we still need to update the v6 ci :)

Suggested change

node-version: [10, 16]

node-version: [10, 18]

@ephys should I update the CI to be similar to main where we have the separate steps?

We have updated the node version to 18 for the Oracle dialect

ephys · 2022-06-19T09:32:17Z

.github/workflows/ci.yml

+      - uses: actions/checkout@v2
+      - uses: actions/setup-node@v1


Also something we have neglected to update 😅

Suggested change

- uses: actions/checkout@v2

- uses: actions/setup-node@v1

- uses: actions/checkout@v3

- uses: actions/setup-node@v3

ephys · 2022-06-19T09:37:07Z

.github/workflows/ci.yml

+      - name: Unit Tests
+        run: yarn test-unit
+      - name: Integration Tests
+        run: yarn test-integration-oracle


What is the current oldest version that is not EOL? Can you add a test against that one too?

With Sequelize, we are planning to support DB version 18.4 and above. currently, we have test (start.sh) for 21.3 DB version and folder is named as latest to fetch latest version always. But as you mentioned to use fixed versions, I shall rename this to 21c. You wanted to add test case for 18.4 too ?

dev/oracle/21-slim/ folder is added to indicate 21c DB version is used as a Oracle docker image.

ephys · 2022-06-19T09:39:28Z

dev/oracle/latest/docker-compose.yml

+services:
+  oraclexedb:
+    container_name: oraclexedb
+    image: gvenzl/oracle-xe:latest


We don't use :latest anymore (though the v6 branch is a bit outdated), we'll make renovate watch this file so it can open a PR when a new major is released :)

Suggested change

image: gvenzl/oracle-xe:latest

image: gvenzl/oracle-xe:21.3.0

We do have to tell renovate to also check the v6 branch though, but that's something we as maintainers will do.

ephys · 2022-06-19T09:42:46Z

dev/oracle/latest/start.sh

+# Granting all the needed privileges to sequelizetest user
+docker exec -t oraclexedb sqlplus system/password@XEPDB1 @privileges.sql
+
+# Setting up Oracle instant client for oracledb


Is this needed to run our tests? :o

Is ~/oracle the recommended folder? I would prefer to not add any file outside of the sequelize directory. Can we move it to a gitignored folder called .oracle at the project root?

If this is needed, is there also a version for Windows that should be added here?

Yes we need to install the Instant client for oracle dialect to work. The privileges are explicitly provided, so that the tests dont just run under higher privileges (like SYSDBA) but under the required privileges. I have moved the installation to Project root/ .oracle folder. I added the .oracle to the .gitignore list. Windows support is added .

ephys · 2022-06-19T11:50:38Z

test/unit/sql/data-types.test.js

        sqlite: 'CHAR BINARY(12)',
        postgres: 'BYTEA'
      });

      testsql('CHAR.BINARY', DataTypes.CHAR.BINARY, {
        default: 'CHAR(255) BINARY',
+        oracle: 'RAW(255)',


is RAW a fixed-length type? If not, this should log a warning (something postgres doesn't do but that is on the "to fix" backlog)

Added a warning 'Oracle CHAR.BINARY datatype is not of Fixed Length.'

ephys · 2022-06-19T11:53:40Z

test/unit/sql/insert.test.js

@@ -91,6 +94,7 @@ describe(Support.getTestDialectTeaser('SQL'), () => {
            mysql: ['2015-01-20 01:00:00'],
            snowflake: ['2015-01-20 01:00:00'],
            mariadb: ['2015-01-20 01:00:00.000'],
+            oracle: [new Date(Date.UTC(2015, 0, 20))],


is this equivalent?

Suggested change

oracle: [new Date(Date.UTC(2015, 0, 20))],

oracle: [new Date(2015, 0, 20)],

The time can vary based on timezone so we are considering the UTC convention

ephys · 2022-06-19T11:55:16Z

test/unit/sql/select.test.js

        default: `SELECT [user].* FROM (${
          [
            `SELECT * FROM (SELECT [user].[id_user] AS [id], [user].[last_name] AS [subquery_order_0], [project_users].[user_id] AS [project_users.userId], [project_users].[project_id] AS [project_users.projectId] FROM [users] AS [user] INNER JOIN [project_users] AS [project_users] ON [user].[id_user] = [project_users].[user_id] AND [project_users].[project_id] = 1 AND [project_users].[status] = 1 ORDER BY [subquery_order_0] ASC${ current.dialect.name === 'mssql' ? ', [user].[id_user]' : ''}${sql.addLimitAndOffset({ limit: 3, order: ['last_name', 'ASC'] })}) AS sub`,
            `SELECT * FROM (SELECT [user].[id_user] AS [id], [user].[last_name] AS [subquery_order_0], [project_users].[user_id] AS [project_users.userId], [project_users].[project_id] AS [project_users.projectId] FROM [users] AS [user] INNER JOIN [project_users] AS [project_users] ON [user].[id_user] = [project_users].[user_id] AND [project_users].[project_id] = 5 AND [project_users].[status] = 1 ORDER BY [subquery_order_0] ASC${ current.dialect.name === 'mssql' ? ', [user].[id_user]' : ''}${sql.addLimitAndOffset({ limit: 3, order: ['last_name', 'ASC'] })}) AS sub`
          ].join(current.dialect.supports['UNION ALL'] ? ' UNION ALL ' : ' UNION ')
-        }) AS [user] ORDER BY [subquery_order_0] ASC;`
+        }) AS [user] ORDER BY [subquery_order_0] ASC;`       


Suggested change

}) AS [user] ORDER BY [subquery_order_0] ASC;`

}) AS [user] ORDER BY [subquery_order_0] ASC;`

ephys · 2022-06-19T11:56:35Z

test/unit/sql/select.test.js

-          default: 'SELECT [User].[name], [User].[age], [Posts].[id] AS [Posts.id], [Posts].[* FROM User; DELETE FROM User;SELECT id] AS [Posts.* FROM User; DELETE FROM User;SELECT id] FROM [User] AS [User] LEFT OUTER JOIN [Post] AS [Posts] ON [User].[id] = [Posts].[user_id];'
-        });
+          oracle: 'SELECT "User"."name", "User"."age", "Posts"."id" AS "Posts.id", "Posts"."* FROM User; DELETE FROM User;SELECT id" AS "Posts.* FROM User; DELETE FROM User;SELECT id" FROM "User" "User" LEFT OUTER JOIN "Post" "Posts" ON "User"."id" = "Posts"."user_id";',
+          default: 'SELECT [User].[name], [User].[age], [Posts].[id] AS [Posts.id], [Posts].[* FROM User; DELETE FROM User;SELECT id] AS [Posts.* FROM User; DELETE FROM User;SELECT id] FROM [User] AS [User] LEFT OUTER JOIN [Post] AS [Posts] ON [User].[id] = [Posts].[user_id];'        });


most tests have default first, then dialect-specific versions

ephys · 2022-06-19T11:57:46Z

test/unit/sql/where.test.js

@@ -495,6 +500,7 @@ describe(Support.getTestDialectTeaser('SQL'), () => {
        [Op.between]: ['2013-01-01', '2013-01-11']
      }, {
        default: "[date] BETWEEN '2013-01-01' AND '2013-01-11'",
+        oracle: '"date" BETWEEN \'2013-01-01\' AND \'2013-01-11\'',


this is the same as default

Yes used default.

WikiRik

Haven't fully checked out the query-generator yet, but I agree with @ephys that it's a high quality PR. Looking forward to seeing the changes implemented and then moving over to a PR for the main branch

WikiRik · 2022-06-19T13:58:01Z

dev/oracle/latest/docker-compose.yml

+services:
+  oraclexedb:
+    container_name: oraclexedb
+    image: gvenzl/oracle-xe:latest


We do have to tell renovate to also check the v6 branch though, but that's something we as maintainers will do.

WikiRik · 2022-06-19T13:59:24Z

.github/workflows/ci.yml

+    strategy:
+      fail-fast: false
+      matrix:
+        node-version: [10, 16]


@ephys should I update the CI to be similar to main where we have the separate steps?

WikiRik · 2022-06-19T14:02:54Z

.github/workflows/ci.yml

+      - name: Unit Tests
+        run: yarn test-unit
+      - name: Integration Tests
+        run: yarn test-integration-oracle


Suggested change

run: yarn test-integration-oracle

run: yarn test-integration

I think that if we specify LD_LIBRARY_PATH in the env variables above this should also work, just for consistency

Yes I have set the LD_LIBRARY_PATH and it is getting populated in test-integration

WikiRik · 2022-06-19T14:05:08Z

dev/oracle/latest/start.sh

+# Granting all the needed privileges to sequelizetest user
+docker exec -t oraclexedb sqlplus system/password@XEPDB1 @privileges.sql
+
+# Setting up Oracle instant client for oracledb


If this is needed, is there also a version for Windows that should be added here?

package.json

WikiRik · 2022-06-19T15:48:30Z

test/unit/sql/select.test.js

-          default: 'SELECT [User].[name], [User].[age], [Posts].[id] AS [Posts.id], [Posts].[* FROM User; DELETE FROM User;SELECT id] AS [Posts.* FROM User; DELETE FROM User;SELECT id] FROM [User] AS [User] LEFT OUTER JOIN [Post] AS [Posts] ON [User].[id] = [Posts].[user_id];'
-        });
+          oracle: 'SELECT "User"."name", "User"."age", "Posts"."id" AS "Posts.id", "Posts"."* FROM User; DELETE FROM User;SELECT id" AS "Posts.* FROM User; DELETE FROM User;SELECT id" FROM "User" "User" LEFT OUTER JOIN "Post" "Posts" ON "User"."id" = "Posts"."user_id";',
+          default: 'SELECT [User].[name], [User].[age], [Posts].[id] AS [Posts.id], [Posts].[* FROM User; DELETE FROM User;SELECT id] AS [Posts.* FROM User; DELETE FROM User;SELECT id] FROM [User] AS [User] LEFT OUTER JOIN [Post] AS [Posts] ON [User].[id] = [Posts].[user_id];'        });


Suggested change

default: 'SELECT [User].[name], [User].[age], [Posts].[id] AS [Posts.id], [Posts].[* FROM User; DELETE FROM User;SELECT id] AS [Posts.* FROM User; DELETE FROM User;SELECT id] FROM [User] AS [User] LEFT OUTER JOIN [Post] AS [Posts] ON [User].[id] = [Posts].[user_id];' });

default: 'SELECT [User].[name], [User].[age], [Posts].[id] AS [Posts.id], [Posts].[* FROM User; DELETE FROM User;SELECT id] AS [Posts.* FROM User; DELETE FROM User;SELECT id] FROM [User] AS [User] LEFT OUTER JOIN [Post] AS [Posts] ON [User].[id] = [Posts].[user_id];'});

WikiRik · 2022-06-19T15:52:42Z

src/dialects/oracle/connection-manager.js

+        // const dialectOptions = config.dialectOptions;
+
+        // //If stmtCacheSize is defined, we set it
+        // if (dialectOptions && 'stmtCacheSize' in dialectOptions) {
+        //   connectionConfig.stmtCacheSize = dialectOptions.stmtCacheSize;
+        // }


Suggested change

// const dialectOptions = config.dialectOptions;

// //If stmtCacheSize is defined, we set it

// if (dialectOptions && 'stmtCacheSize' in dialectOptions) {

// connectionConfig.stmtCacheSize = dialectOptions.stmtCacheSize;

// }

WikiRik · 2022-06-19T15:53:07Z

src/dialects/oracle/connection-manager.js

+          throw new SequelizeErrors.HostNotReachableError(err); //ORA-12154: TNS:could not resolve the connect identifier specified
+        case 'ORA-12514': // ORA-12514: TNS:listener does not currently know of service requested in connect descriptor
+          throw new SequelizeErrors.HostNotFoundError(err);
+        // case 'ORA-12541': // ORA-12541: TNS:No listener


Why is this commented out?

We have addressed it.

WikiRik · 2022-06-19T16:06:48Z

package.json

@@ -261,13 +267,15 @@
    "test-integration-mssql": "cross-env DIALECT=mssql npm run test-integration",
    "test-integration-db2": "cross-env DIALECT=db2 npm run test-integration",
    "test-integration-snowflake": "cross-env DIALECT=snowflake npm run test-integration",
+    "test-integration-oracle": "cross-env LD_LIBRARY_PATH=$HOME/oracle/instantclient/ DIALECT=oracle UV_THREADPOOL_SIZE=128 npm run test-integration",


I'm using GitHub Codespaces, running Node 16 and starting Oracle seems to work fine but I can't run integration tests.

SequelizeConnectionError: DPI-1047: Cannot locate a 64-bit Oracle Client library: "libaio.so.1: cannot open shared object file: No such file or directory". See https://oracle.github.io/node-oracledb/INSTALL.html for help Node-oracledb installation instructions: https://oracle.github.io/node-oracledb/INSTALL.html You must have 64-bit Oracle Client libraries configured with ldconfig, or in LD_LIBRARY_PATH. If you do not have Oracle Database on this computer, then install the Instant Client Basic or Basic Light package from https://www.oracle.com/database/technologies/instant-client/linux-x86-64-downloads.html

The libaio package needs to be added manually and is not part of the instant client.
It looks like its not installed in VM/container?
The instructions details are here :
https://oracle.github.io/node-oracledb/INSTALL.html (grep for libaio )

WikiRik · 2022-06-19T16:28:44Z

src/dialects/oracle/query.js

+
+const debug = logger.debugContext('sql:oracle');
+
+class Query extends AbstractQuery {


Partially at @ephys do we want to name this OracleQuery?

I missed it but yes :)

Used OracleQuery

src/dialects/oracle/query-generator.js

src/dialects/oracle/connection-manager.js

src/dialects/oracle/data-types.js

src/dialects/oracle/query-generator.js

* fix: addressing review comments

* fix: minor fixes to the review comments

* fix: doc gen is fixed

* fix: autogenerate the primary constraint name

WikiRik · 2022-08-08T18:30:55Z

@sudarshan12s sorry for the long wait, but I hope to be able to take another look at this later this week

Abdel-Monaam-Aouini · 2022-08-12T08:07:39Z

@sudarshan12s sorry for the long wait, but I hope to be able to take another look at this later this week

nice :D

cjbj · 2022-08-22T06:53:26Z

@Monaam12 @WikiRik another ping to make sure we can land this PR soon.

14gasher · 2022-08-31T21:35:57Z

Any updates on this perchance?

package.json

sdepold · 2022-09-07T18:46:45Z

package.json

@@ -239,17 +244,20 @@
    "start-postgres": "bash dev/postgres/10/start.sh",
    "start-mssql": "bash dev/mssql/2019/start.sh",
    "start-db2": "bash dev/db2/11.5/start.sh",
+    "start-oracle": "bash dev/oracle/21-slim/start.sh",


Is this supposed to work on Apple Silicone?

host logs

[v6][~/Projects/sequelize]$ yarn start-oracle yarn run v1.22.15 $ bash dev/oracle/21-slim/start.sh ++ dirname -- dev/oracle/21-slim/start.sh + cd -P -- dev/oracle/21-slim + docker-compose -p oraclexedb down --remove-orphans Removing oraclexedb ... done Removing network sequelize-oraclexedb-network + docker-compose -p oraclexedb up -d Creating network "sequelize-oraclexedb-network" with the default driver Creating oraclexedb ... done + ./wait-until-healthy.sh oraclexedb oraclexedb is healthy! + docker cp privileges.sql oraclexedb:/opt/oracle/. + docker exec -t oraclexedb sqlplus system/password@XEPDB1 @privileges.sql Error response from daemon: Container 76313f78c153efd601426ac8534d2ac45d2666fc200b0c2a78b0e212e7fc1111 is not running error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

container logs

The command completed successfully ERROR: ORA-12547: TNS:lost contact SP2-0306: Invalid option. Usage: CONN[ECT] [{logon|/|proxy} [AS {SYSDBA|SYSOPER|SYSASM|SYSBACKUP|SYSDG|SYSKM|SYSRAC}] [edition=value]] where <logon> ::= <username>[/<password>][@<connect_identifier>] <proxy> ::= <proxyuser>[<username>][/<password>][@<connect_identifier>] SP2-0306: Invalid option. Usage: CONN[ECT] [{logon|/|proxy} [AS {SYSDBA|SYSOPER|SYSASM|SYSBACKUP|SYSDG|SYSKM|SYSRAC}] [edition=value]] where <logon> ::= <username>[/<password>][@<connect_identifier>] <proxy> ::= <proxyuser>[<username>][/<password>][@<connect_identifier>] SP2-0157: unable to CONNECT to ORACLE after 3 attempts, exiting SQL*Plus

It would only work on Apple Silicon under Rosetta because the Oracle Instant Client is not available on Apple Silicon due to some 3rd party libraries not being available.

sdepold · 2022-09-07T18:50:07Z

src/dialects/abstract/query-generator.js

-    query = `${replacements.attributes.length ? valueQuery : emptyQuery};`;
+    if (this._dialect.supports.returnIntoValues && options.returning) {
+      // Populating the returnAttributes array and performing operations needed for output binds of insertQuery 
+      this.getInsertQueryReturnIntoBinds(returnAttributes, bind.length, returningModelAttributes, returnTypes, options);


Hm. What is this doing? As far as I can tell, we never override getInsertQueryReturnIntoBinds anywhere and the defined abstract function is a noop?

For the Oracle dialect we generate sql statement like these - INSERT INTO "Campuses" ("id","name","address","description","createdAt","updatedAt") VALUES (DEFAULT,:1,:2,:3,:4,:5) RETURNING "id","name","address","description","createdAt","updatedAt" INTO :6,:7,:8,:9,:10,:11;

getInsertQueryReturnIntoBinds function generates the bind values for outBinds (:6,:7,:8,:9,:10,:11 in the above sql) , generates the bindDefs for the out binds and also populates the options.outBindAttributes field.

Yes, this function is only used by the Oracle dialect, for now, we have defined an abstract function with a noop so that other dialects can override it if required.

src/dialects/abstract/query-generator.js

populateInsertQueryReturnIntoBinds

dev/oracle/21-slim/wait-until-healthy.sh

src/dialects/abstract/query-generator.js

src/dialects/oracle/connection-manager.js

sdepold · 2022-09-12T18:34:19Z

src/dialects/oracle/index.js

+  GEOMETRY: false
+});
+
+OracleDialect.prototype.defaultVersion = '18.4.0';


so this implementation supports all oracle versions starting from 18.4? Do we test against that version on CI?

sdepold · 2022-09-12T18:40:39Z

src/model.js

@@ -2645,7 +2645,7 @@ class Model {
        }
      }

-      if (options.ignoreDuplicates && ['mssql', 'db2'].includes(dialect)) {
+      if (options.ignoreDuplicates && ['mssql', 'db2', 'oracle'].includes(dialect)) {


Do we have access to the dialect.supports.ignoreDuplicates here?

Yes its accessable. I see it can be added like this by checking if these properties are left default.

if (options.ignoreDuplicates && this.sequelize.dialect.supports.inserts.ignoreDuplicates === '' && this.sequelize.dialect.supports.inserts.onConflictDoNothing === '') {

sdepold · 2022-09-12T18:41:46Z

test/integration/associations/belongs-to-many.test.js

@@ -1417,7 +1417,7 @@ describe(Support.getTestDialectTeaser('BelongsToMany'), () => {

  describe('hasAssociations with binary key', () => {
    beforeEach(function() {
-      const keyDataType = ['mysql', 'mariadb', 'db2'].includes(dialect) ? 'BINARY(255)' : DataTypes.BLOB('tiny');
+      const keyDataType = ['mysql', 'mariadb', 'db2'].includes(dialect) ? 'BINARY(255)' : dialect === 'oracle' ? DataTypes.STRING(255, true) : DataTypes.BLOB('tiny');


Please refactor this to avoid the nested ternary operator.

sdepold · 2022-09-12T18:44:15Z

test/unit/query-interface/bulk-insert.test.js

@@ -13,7 +14,7 @@ describe('QueryInterface#bulkInsert', () => {
  });

  // you'll find more replacement tests in query-generator tests
-  it('does not parse replacements outside of raw sql', async () => {
+  (dialect !== 'oracle' ? it : it.skip)('does not parse replacements outside of raw sql', async () => {


Are you going to work on this?

* fix: incorporated review comments

sdepold · 2022-09-14T18:06:07Z

src/model.js

@@ -2644,8 +2644,8 @@ class Model {
          options.returning = true;
        }
      }
-
-      if (options.ignoreDuplicates && ['mssql', 'db2', 'oracle'].includes(dialect)) {
+      if (options.ignoreDuplicates && this.sequelize.dialect.supports.inserts.ignoreDuplicates === '' &&


Holy mother of Jesus, I didn't expect that thing to be a string. Since empty strings are false, I wonder if we should go with

options.ignoreDuplicates && !this.sequelize.dialect.supports.inserts.ignoreDuplicates

Why do we consider onConflictDoNothing suddenly?

Without adding onConflictDoNothing, I see this test case for postgresql was failing.

test/integration/model/bulk-create.test.js 1) should support the ignoreDuplicates option

The test case enables ignoreDuplicates option under a check if either of property; ignoreDuplicates or onConflictDoNothing is non-null. Hence validating against only supports.inserts.ignoreDuplicates throws an error.

Error: postgres does not support the ignoreDuplicates option.

I modified to use ! for string empty check.
on the CI using latest version, can we add the lower version 18.4 in a separate PR?

sdepold · 2022-09-14T18:10:05Z

I think the code is in a decent shape now. There is this one open question about onConflictDoNothing but other than that I'm fine. Since I cannot find my own comment on this anymore, I think it would make sense to test for the latest and the lowest supported version on CI

sudarshan12s · 2022-09-15T04:31:23Z

I updated my understanding onConflictDoNothing property.
Can we add the lower version 18.4 in a separate PR?

WikiRik · 2022-09-15T12:08:01Z

I'm fine with adding 18.4 CI testing in a separate PR. I think that with these latest change we should be good to go. @sdepold agree?

Outdated

sdepold · 2022-09-15T18:01:00Z

Let's do it!

sdepold · 2022-09-15T18:11:26Z

Huge kudos to you and your team for the great contribution :)

github-actions · 2022-09-15T18:45:33Z

🎉 This PR is included in version 6.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Abdel-Monaam-Aouini · 2022-09-16T08:43:32Z

@sdepold sequelize/website#210 related to this PR

feat(oracle): add oracle dialect support (#1)

3ff1598

* feat(oracle): add oracle dialect support

cjbj mentioned this pull request Jun 15, 2022

Sequelize dialect for Oracle Database ! oracle/node-oracledb#1504

Closed

ephys requested review from ephys, WikiRik and sdepold June 16, 2022 18:22

ephys previously requested changes Jun 19, 2022

View reviewed changes

WikiRik reviewed Jun 19, 2022

View reviewed changes

Merge branch 'sequelize:v6' into v6

01ade20

cjbj reviewed Jun 23, 2022

View reviewed changes

sudarshan12s added 5 commits June 24, 2022 02:07

fix: addressing review comments (#7)

2cda49b

* fix: addressing review comments

fix: minor fixes done (#9)

42ff129

* fix: minor fixes to the review comments

fix: merge from sequelize-v6

0dba368

fix: enable newly added unit tests for Oracle dialect

1ae6673

fix: remove dangling comma (#13)

478728d

* fix: doc gen is fixed

This was referenced Jun 28, 2022

feat: Add Oracle dialect specific documentation for v6 sequelize/website#208

Closed

feat: Add Oracle dialect specific documentation V7 sequelize/website#187

Closed

sudarshan12s added 3 commits June 30, 2022 14:13

fix: autogenerate the primary constraint name (#14)

a9c456e

* fix: autogenerate the primary constraint name

Merge branch 'v6' into v6

8f6a2d2

fix: remove trailing comma

4cc8ace

WikiRik mentioned this pull request Jul 24, 2022

supporting oracledb #14793

Closed

8 tasks

Merge branch 'sequelize:v6' into v6

b1beb88

sudarshan12s added 2 commits August 29, 2022 09:29

Merge branch 'sequelize:v6' into v6

a076945

fix: make changes to ORADERBY as per v6 sync

336ef8e

sdepold reviewed Sep 7, 2022

View reviewed changes

sudarshan12s added 2 commits September 8, 2022 12:20

Merge branch 'sequelize:v6' into v6

fcdd47f

fix: move test-unit-oracle above test-unit-all

9c0de49

sudarshan12s added 3 commits September 12, 2022 13:32

Merge branch 'sequelize:v6' into v6

7ad96bf

fix: rename getInsertQueryReturnIntoBinds to

1213de3

populateInsertQueryReturnIntoBinds

fix: reorder parameters for function populateInsertQueryReturnIntoBinds

afedbf6

sdepold reviewed Sep 12, 2022

View reviewed changes

fix: incorporated review comments (#16)

084cd81

* fix: incorporated review comments

sdepold reviewed Sep 14, 2022

View reviewed changes

fix: modify string empty check with !

f0a5494

sdepold approved these changes Sep 15, 2022

View reviewed changes

sdepold merged commit c230d80 into sequelize:v6 Sep 15, 2022

github-actions bot added the released label Sep 15, 2022

	image: gvenzl/oracle-xe:latest
	image: gvenzl/oracle-xe:21.3.0

	oracle: [new Date(Date.UTC(2015, 0, 20))],
	oracle: [new Date(2015, 0, 20)],

	}) AS [user] ORDER BY [subquery_order_0] ASC;`
	}) AS [user] ORDER BY [subquery_order_0] ASC;`

	default: 'SELECT [User].[name], [User].[age], [Posts].[id] AS [Posts.id], [Posts].[* FROM User; DELETE FROM User;SELECT id] AS [Posts.* FROM User; DELETE FROM User;SELECT id] FROM [User] AS [User] LEFT OUTER JOIN [Post] AS [Posts] ON [User].[id] = [Posts].[user_id];' });
	default: 'SELECT [User].[name], [User].[age], [Posts].[id] AS [Posts.id], [Posts].[* FROM User; DELETE FROM User;SELECT id] AS [Posts.* FROM User; DELETE FROM User;SELECT id] FROM [User] AS [User] LEFT OUTER JOIN [Post] AS [Posts] ON [User].[id] = [Posts].[user_id];'});


		const debug = logger.debugContext('sql:oracle');

		class Query extends AbstractQuery {

feat(oracle): add oracle dialect support #14638

feat(oracle): add oracle dialect support #14638

Conversation

sudarshan12s commented Jun 14, 2022 • edited

Pull Request Checklist

Description Of Change

Minimum Supported version of dependency

Todos

ephys left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sudarshan12s Jun 24, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sudarshan12s Jun 24, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sudarshan12s Jun 24, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WikiRik left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WikiRik commented Aug 8, 2022

Abdel-Monaam-Aouini commented Aug 12, 2022

cjbj commented Aug 22, 2022

14gasher commented Aug 31, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nilabja-bhattacharya Sep 8, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sdepold commented Sep 14, 2022

sudarshan12s commented Sep 15, 2022

WikiRik commented Sep 15, 2022

sdepold commented Sep 15, 2022

sdepold commented Sep 15, 2022

github-actions bot commented Sep 15, 2022

Abdel-Monaam-Aouini commented Sep 16, 2022

sudarshan12s commented Jun 14, 2022 •

edited

sudarshan12s Jun 24, 2022 •

edited

sudarshan12s Jun 24, 2022 •

edited

sudarshan12s Jun 24, 2022 •

edited

nilabja-bhattacharya Sep 8, 2022 •

edited