New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): deduplicate error typings #14002
Conversation
Just to check, this is compatible with the v6 branch right? |
It should be. I've aligned the new files with the old typing definitions. But I'll double check that everything that was exported, still is |
I was mostly thinking about files that weren't converted to TS in the v6 branch but I haven't looked at your changes yet. |
These files were converted to TS just before we stopped the migration for v6 :) https://github.com/sequelize/sequelize/tree/v6/lib/errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
🎉 This PR is included in version 7.0.0-alpha.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Pull Request Checklist
npm run test
ornpm run test-DIALECT
pass with this change (including linting)?Description Of Change
Closes #14000, I hope
This PR deduplicates the typing definitions for Error classes, as
types/lib/errors.d.ts
wasn't removed and was shadowinglib/errors
.I also fixed issues detected in
lib/errors
once it wasn't shadowed anymore