Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta(deps): update (dev)deps #13836

Merged
merged 2 commits into from Dec 28, 2021
Merged

meta(deps): update (dev)deps #13836

merged 2 commits into from Dec 28, 2021

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Dec 28, 2021

Since renovate does not seem to work yet. For dependencies with versions 1 or above I updated minor and patch versions, for dependencies still on 0.x I updated only patch versions.

Can be merged to v6 as well if needed

sdepold
sdepold reviewed Dec 28, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
sdepold
sdepold reviewed Dec 28, 2021
View reviewed changes
Copy link
Member

@sdepold sdepold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

sdepold
sdepold requested changes Dec 28, 2021
View reviewed changes
Copy link
Member

@sdepold sdepold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

package.json Outdated Show resolved Hide resolved
@sdepold
Copy link
Member

sdepold commented Dec 28, 2021

I have somehow royally screwed up the comments now :D

@WikiRik
Copy link
Member Author

WikiRik commented Dec 28, 2021

Unit tests are indeed failing on esbuild 0.14.8, will try various versions locally to pin-point what esbuild changes caused this so we can fix this here/in a future PR

@WikiRik
Copy link
Member Author

WikiRik commented Dec 28, 2021

@ephys changes from esbuild 0.14.3 - 0.14.4 caused the issue (but use 0.14.5 because of a wrong published version); https://github.com/evanw/esbuild/releases
Can you check it out and make a new PR to fix it? Should not be difficult I think but I can't really wrap my head around this stuff yet

@WikiRik WikiRik requested a review from sdepold December 28, 2021 12:36
@ephys
Copy link
Member

ephys commented Dec 28, 2021 •
edited

(on phone): we can't update esbuild for V6 because they fix the workaround used in operators.ts

If this is targeting V7, we can resolve the workaround and update esbuild :)

Edit: oh I see you're already aware

@sdepold sdepold merged commit f3137c9 into sequelize:main Dec 28, 2021
sdepold pushed a commit that referenced this pull request Dec 28, 2021
@WikiRik @sdepold
meta(deps): update (dev)deps (#13836)
899b3ed 
* meta(deps): update (dev)deps

* meta(deps): lock esbuild to 0.14.3

Co-authored-by: Rik Smale <WikiRik@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2022

🎉 This PR is included in version 7.0.0-alpha.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2022

🎉 This PR is included in version 7.0.0-alpha2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@WikiRik WikiRik deleted the deps-minor-updates branch January 4, 2022 12:00
aliatsis pushed a commit to creditiq/sequelize that referenced this pull request Jun 2, 2022
@WikiRik @aliatsis
meta(deps): update (dev)deps (sequelize#13836)
4747ea7 
* meta(deps): update (dev)deps

* meta(deps): lock esbuild to 0.14.3

Co-authored-by: Rik Smale <WikiRik@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdepold sdepold sdepold approved these changes

Assignees
No one assigned
Labels
released on @alpha released on @v7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WikiRik @sdepold @ephys