New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mssql/async-queue): fix unable to start mysql due to circular ref #13823
Conversation
Thanks for the Pull Request! Are there any tests that we can add to this? |
Hm. I just started the MySQL setup and it worked perfectly fine. Will have another look tomorrow |
|
That is on master. Not sure if we need to fix anything?! |
If |
Well, the test is that sequelize can be imported and runs :) Because a circular ref breaks everything. I'm not sure how this kind of error was merged to the main branch undetected. |
As much as I cannot reproduce this issue, I think the change makes sense in general |
…#13823) Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
Released in 6.12.4 |
Merry Xmas! Thanks for reviewing this PR. I did notice the build did not fail in CI but I didn't have much time to investigate further. I tried again today I notice I can reproduce the error with Then I think it's an issue with lock file because there isn't an Then I tried to upgrade To reproduce with npm
To reproduce with yarn
|
Likewise.
Right. That is what I did, Cheers. |
Cash you confirm that it works in the new version? |
Yes, the change in this PR works with the new version. |
Sweet |
🎉 This PR is included in version 7.0.0-alpha.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 7.0.0-alpha2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
…sequelize#13823) Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
Pull Request Checklist
Please make sure to review and check all of these items:
npm run test
ornpm run test-DIALECT
pass with this change (including linting)?Description Of Change
Fix unable to start mysql docker in test due to circular reference
Why this happen? Because on this line, it attempts to export an Error that's outside
errors
dir and this outside AsyncQueueError has circular reference toerrors/index.ts
sequelize/lib/errors/index.ts
Line 36 in 8cdce6a
It's a bit weird to me that
errors/index.ts
attempts to expose an Error that's outside this dir, maybe it shouldn't do it in the first place but removing it will be a breaking change so I'll not change it in this PR. Taking it out requires a different discussion.Steps to reproduce
Node: v14.18.1
run the follow command
and received the following error