Bring back quoteIdentifier(s) to queryInterface to ease migration to v6 #13810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdepold
commented
Dec 22, 2021
sdepold
commented
Dec 22, 2021
sdepold
commented
Dec 22, 2021
WikiRik
approved these changes
Dec 22, 2021
|
🎉 This PR is included in version 6.12.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
aliatsis
pushed a commit
to creditiq/sequelize
that referenced
this pull request
Jun 2, 2022
…sequelize#13810) * fix(query-generator): update documentation of quoteIdentifier(s) * fix(query-interface): bring back quoteIdentifier(s) to queryInterface * fix(formatting): fix linting of class-to-invokable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description Of Change
In some version of v6, the queryInterface apparently lost
quoteIdentifierandquoteIdentifierswhich is hindering people to update to v6 (#12627). Interestingly, the types haven't been updated accordingly. So there is a certain discrepancy. This PR is recovering the methods.