Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(13804): use schema for ARRAY(ENUM) type name #13807

Merged
merged 3 commits into from Dec 22, 2021

Conversation

nahog
Copy link
Contributor

@nahog nahog commented Dec 21, 2021

Pull Request Checklist

Please make sure to review and check all of these items:

  • Have you added new tests to prevent regressions?
  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description Of Change

Closes #13804

This change is also realated with #13204 PR #13210. It not caused by it but the source of both bugs is the same, improper handling of ARRAY[ENUM] on postgres. In this scenario is only when we are using schemas.

@WikiRik WikiRik added dialect: postgres For issues and PRs. Things that involve PostgreSQL (and do not involve all dialects). status: wip For issues and PRs. Applied when the PR is not ready yet / when work to close the issue has started. labels Dec 21, 2021
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe your new test is not correct, can you check?

test/integration/dialects/postgres/dao.test.js Outdated Show resolved Hide resolved
@WikiRik WikiRik requested a review from sdepold December 21, 2021 21:11
@sdepold sdepold merged commit da5b0ce into sequelize:main Dec 22, 2021
@sdepold
Copy link
Member

sdepold commented Dec 22, 2021

thx!

@sdepold sdepold mentioned this pull request Dec 22, 2021
4 tasks
@github-actions
Copy link
Contributor

🎉 This PR is included in version 6.12.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

aliatsis pushed a commit to creditiq/sequelize that referenced this pull request Jun 2, 2022
…elize#13807)

* fix(13804): use schema for ARRAY(ENUM) type name

* fix(31804): Update integration test

Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialect: postgres For issues and PRs. Things that involve PostgreSQL (and do not involve all dialects). released status: wip For issues and PRs. Applied when the PR is not ready yet / when work to close the issue has started.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enums data types does not honor schema names in postgres
3 participants