Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TS support for operators.ts #13805

Merged
merged 1 commit into from Dec 22, 2021
Merged

Fix TS support for operators.ts #13805

merged 1 commit into from Dec 22, 2021

Conversation

ephys
Copy link
Member

@ephys ephys commented Dec 21, 2021

Pull Request Checklist

Please make sure to review and check all of these items:

  • [n/a] Have you added new tests to prevent regressions?
  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • [n/a] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description Of Change

Closes #13791

Fix turned out more complicated than previously thought (#13797)

Current solution is definitely a hack to please both TypeScript and Node.

I think the TypeScript migration is going to keep breaking things due to how esbuild transpiles ESM. I've opened an issue regarding this as the decision will impact this PR #13806

@WikiRik
Copy link
Member

WikiRik commented Dec 21, 2021

Yeah, I'm starting to think the TypeScript migration might be better for v7. There are already various things that we've found from the conversion that we want to change and it gives a better overview to do them directly then add comments in the code that we need to refactor later. But let's discuss that at the next meeting in January; can you add things you've noticed about the migration to sequelize/meetings#6 ?

@ephys
Copy link
Member Author

ephys commented Dec 21, 2021

Oh thanks! I was looking for a place to put such a discussion and didn't think to use the meetings repo. Will do :)

@WikiRik
Copy link
Member

WikiRik commented Dec 22, 2021

@sdepold time for a 6.12.2?

@github-actions
Copy link
Contributor

🎉 This PR is included in version 6.12.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ephys ephys deleted the feature/issue-13791-v3 branch February 8, 2022 12:11
aliatsis pushed a commit to creditiq/sequelize that referenced this pull request Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript 4.5.4 does not like sequelize-ESM imports in v6.12
3 participants