fix(data-types): unnecessary warning when getting data with DATE dataTypes

[fzn0x]

Pull Request Checklist

Please make sure to review and check all of these items:

• Have you added new tests to prevent regressions?
• Does npm run test or npm run test-DIALECT pass with this change (including linting)?
• Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
• Did you update the typescript typings accordingly (if applicable)?
• Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
• Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description Of Change

unnecessary warning when getting data with DATE dataTypes attributes.

Todos

• check if value is date

[sdepold]

Can we have a test that ensures that the situation has improved?

[fzn0x]

Can we have a test that ensures that the situation has improved?

Look like checking this warning has resolve or not cannot be checked with unit test, only manual test. Correct me if I'm wrong.

[fzn0x]

You can check by manual test with

  const crowdFundings = await CrowdFunding.findAndCountAll({
    distinct: true, // don't count the include part https://github.com/sequelize/sequelize/pull/4016#issuecomment-116294996
    attributes: [
     'date_attributes' // <- will cause the warning from momentjs
    ],
    include: [{ all: true }],
    where: {
      ...data,
      [Op.or]: searchUtil.search(crowdFundingAttributes, query.q || ""),
    },
    ...pagination.getPaginationOptionsData(),
  });

I take this codebase from my project haha

[sdepold]

Is the result of the function different if it is not a date?

[fzn0x]

Is the result of the function different if it is not a date?

No, it's just produce momentjs warning which may some developers don't like, so I improve it to just apply timezone when the value in the correct format.

[WikiRik]

I don't think we need to merge this, especially if #13372 will be done soon

[fzn0x]

I don't think we need to merge this, especially if #13372 will be done soon

It might be implemented too but we don't have an updated PR for it. So merge this now will still be needed as minor improvement so someone not confusing with this kind of error just because we apply timezone for non-Date values.

[fzn0x]

Also we need to check the value first if it's date or not, whether it is using momentjs or others

[WikiRik]

Sure, then this looks good

[github-actions]

🎉 This PR is included in version 6.12.0-beta.1 🎉

The release is available on:

• npm package (@v6-beta dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[github-actions]

🎉 This PR is included in version 6.12.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[moonjoungyoung]

@fncolon @sdepold

Hello.
After this PR, using moment objects are throwing error.
Is this an intended modification?

[fzn0x]

@fncolon @sdepold

Hello. After this PR, using moment objects are throwing error. Is this an intended modification?

Hello, can you reproduce your example in an issue? technicallly it's just check a raw date value.

[cmelendez]

@fncolon @sdepold
Hello. After this PR, using moment objects are throwing error. Is this an intended modification?

Hello, can you reproduce your example in an issue? technicallly it's just check a raw date value.

Hi @fncolon.

We upgraded from 6.9.0 to 6.12.1 today and our app started throwing errors when using a Moment object to do equality checks. I'm not sure if this PR is the cause but it seems to be similar to the problem described by @moonjoungyoung.

Here's a piece of code that is throwing a Invalid value Moment<2021-12-21T19:52:23+00:00> error. It's part of a where clause.

phone_validation_until: {
   [Op.gte]: moment()
  },

Thanks.

[cmelendez]

Some extra info:

• When setting any date value with moment, the stored value is 0000-00-00 00:00:00.
• We are using mysql.
• Moment objects works perfectly up to 6.11.0. Issues starts with >=6.12.0.

edit: pinging @sdepold

[fzn0x]

@fncolon @sdepold

Hello. After this PR, using moment objects are throwing error. Is this an intended modification?

Just find out the problem, it was returning date instead of formatted date, also change isDate from lodash with isMoment from moment.

[fzn0x]

Some extra info:

• When setting any date value with moment, the stored value is 0000-00-00 00:00:00.
• We are using mysql.
• Moment objects works perfectly up to 6.11.0. Issues starts with >=6.12.0.

edit: pinging @sdepold

Just created the pull request in #13818, thanks!