New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): add hooks to InstanceDestroyOptions type #13491
Merged
ephys
merged 6 commits into
sequelize:main
from
apazzolini:fix-instancedestroyoptions-types
Jan 12, 2022
Merged
fix(types): add hooks to InstanceDestroyOptions type #13491
ephys
merged 6 commits into
sequelize:main
from
apazzolini:fix-instancedestroyoptions-types
Jan 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keimeno
added
the
type: typescript
For issues and PRs. Things that involve typescript, such as typings and intellisense.
label
Oct 10, 2021
Looks good to me but we should add a typing test to prevent a regression. It's been a while since you've opened this PR, I'll add it for you |
ephys
approved these changes
Jan 12, 2022
WikiRik
approved these changes
Jan 12, 2022
ephys
changed the title
Add hooks to InstanceDestroyOptions type
fix(types): add hooks to InstanceDestroyOptions type
Jan 12, 2022
sdepold
added a commit
that referenced
this pull request
Jan 22, 2022
Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com> Co-authored-by: Zoé <zoe@ephys.dev>
🎉 This PR is included in version 7.0.0-alpha.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
aliatsis
pushed a commit
to creditiq/sequelize
that referenced
this pull request
Jun 2, 2022
Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com> Co-authored-by: Zoé <zoe@ephys.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
released on @v7
type: typescript
For issues and PRs. Things that involve typescript, such as typings and intellisense.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
In the model
destroy
method, the code allows for the user to specifyhooks
, which was missing from theInstanceDestroyOptions
type definition.See:
sequelize/lib/model.js
Lines 4150 to 4197 in 56bb1d6