Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): add missing fields to FindOr{Create,Build}Options #13389

Merged
merged 6 commits into from Jan 12, 2022
Merged

fix(types): add missing fields to FindOr{Create,Build}Options #13389

merged 6 commits into from Jan 12, 2022

Conversation

devagrawal09
Copy link
Contributor

@devagrawal09 devagrawal09 commented Jul 20, 2021 •
edited

Fixes #13388

wbourne0
wbourne0 previously requested changes Oct 11, 2021
View reviewed changes
Copy link
Member

@wbourne0 wbourne0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can you add a test to test/types to prevent regressions? Thanks.

@wbourne0 wbourne0 added status: awaiting response For issues and PRs. OP must respond (or change something, if it is a PR). Maintainers have no action type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense. labels Oct 11, 2021
@wbourne0 wbourne0 self-assigned this Oct 11, 2021
@github-actions github-actions bot added the stale label Oct 27, 2021
@github-actions github-actions bot closed this Nov 2, 2021
@fzn0x fzn0x reopened this Nov 10, 2021
@WikiRik WikiRik removed the stale label Nov 10, 2021
@github-actions github-actions bot added the stale label Nov 25, 2021
@ephys ephys removed the stale label Jan 6, 2022
@ephys ephys self-assigned this Jan 6, 2022
@ephys
Copy link
Member

ephys commented Jan 6, 2022

This PR has been untouched for a while, I've taken the liberty of adding the necessary test.

I've also split FindOrCreateOptions into FindOrCreateOptions and FindOrBuildOptions as findOrBuild used the same type even though it accepted different inputs.

@ephys ephys requested a review from wbourne0 January 6, 2022 14:36
@github-actions github-actions bot removed the status: awaiting response For issues and PRs. OP must respond (or change something, if it is a PR). Maintainers have no action label Jan 6, 2022
@ephys ephys requested a review from WikiRik January 12, 2022 10:29
@ephys ephys changed the title fix(types): findorcreate options extends create options fix(types): add missing fields to FindOr{Create,Build]Options Jan 12, 2022
@ephys ephys changed the title fix(types): add missing fields to FindOr{Create,Build]Options fix(types): add missing fields to FindOr{Create,Build}Options Jan 12, 2022
@ephys ephys merged commit 81b0b9d into sequelize:main Jan 12, 2022
sdepold pushed a commit that referenced this pull request Jan 22, 2022
@devagrawal09 @ephys @sdepold
fix(types): add missing fields to FindOr{Create,Build}Options (#13389)
ef63f8f 
Co-authored-by: Zoé <zoe@ephys.dev>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2022

🎉 This PR is included in version 7.0.0-alpha.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

aliatsis pushed a commit to creditiq/sequelize that referenced this pull request Jun 2, 2022
@devagrawal09 @ephys @aliatsis
fix(types): add missing fields to FindOr{Create,Build}Options (sequel…
65c03d7 
…ize#13389)

Co-authored-by: Zoé <zoe@ephys.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WikiRik WikiRik WikiRik approved these changes

@wbourne0 wbourne0 Awaiting requested review from wbourne0

Assignees

@ephys ephys

@wbourne0 wbourne0

Labels
released on @v7 type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FindOrCreateOptions does not extend CreateOptions
5 participants
@devagrawal09 @ephys @WikiRik @wbourne0 @fzn0x