fix(types): add missing transaction typescript types (v5)

[aecorredor]

Pull Request check-list

• Does npm run test or npm run test-DIALECT pass with this change (including linting)?
• Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
• Have you added new tests to prevent regressions?
• Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
• Did you update the typescript typings accordingly (if applicable)?
• Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

As stated in the sequelize docs (https://sequelize.org/master/class/lib/transaction.js~Transaction.html#static-get-LOCK), when performing find operations, a lock property can be passed, and that can be either true or false or also a lock level obtained from the actual instance, i.e. t1.LOCK.UPDATE, which ends up being a string.

The TypeScript types were failing when trying to pass a boolean value to lock or when trying to access t1.LOCK... on a transaction instance.

This PR adds those missing types.

Link to existing issue: #11178 (comment)

Link to v6-beta PR: #11620

[codecov]

Codecov Report

Merging #11621 into v5 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##               v5   #11621   +/-   ##
=======================================
  Coverage   96.27%   96.27%           
=======================================
  Files          94       94           
  Lines        9187     9187           
=======================================
  Hits         8845     8845           
  Misses        342      342

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2083c9a...a1d0608. Read the comment docs.

[swaibat]

@aecorredor great job

[papb]

LGTM, same as #11620

[sushantdhiman]

🎉 This PR is included in version 5.21.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[danconnell]

When I try to use 5.21.2, I'm seeing these errors on compilation:

node_modules/sequelize/types/lib/transaction.d.ts:33:14 - error TS1086: An accessor cannot be declared in an ambient context.

33   static get LOCK(): LOCK;
                ~~~~

node_modules/sequelize/types/lib/transaction.d.ts:40:7 - error TS1086: An accessor cannot be declared in an ambient context.

40   get LOCK(): LOCK;
         ~~~~

Is this expected?

[papb]

Definitely not expected, this is surprising, I thought our tests would have picked this up. Are you using some specific version of typescript or something that to the best of your knowledge could be involved in this?

[danconnell]

Ah, upgrading to typescript@3.6.4 (we were on 3.5.3 - which is only a few months old) fixed the issue.

Weird. Thanks for suggesting that.

[papb]

😬 Awesome. To be honest I didn't expect it to be that simple...

[notoriousmango]

I am getting the error

node_modules/sequelize/types/lib/transaction.d.ts:33:14 - error TS1086: An accessor cannot be declared in an ambient context.

33   static get LOCK(): LOCK;
                ~~~~

node_modules/sequelize/types/lib/transaction.d.ts:40:7 - error TS1086: An accessor cannot be declared in an ambient context.

40   get LOCK(): LOCK;
         ~~~~

My packages

"dependencies": {
    "@types/bluebird": "^3.5.28",
    "@types/node": "^12.12.7",
    "@types/validator": "^10.11.3",
    "mysql2": "^2.0.0",
    "sequelize": "^5.21.2",
    "typescript": "^3.7.2"
  },

should i downgrade my typescript to typescript@3.6.4

[papb]

@notoriousmango Please try downgrading and let us know if it works.

Note: this is just in order to help us figure it out, of course Sequelize should work with the latest TS. We shall figure it out.

[notoriousmango]

@papb Sorry, my global typescript was outdated.
It works fine when I updated the global typescript