Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(security): add responsible disclosure policy #11300

Merged
merged 2 commits into from Aug 11, 2019

Conversation

lirantal
Copy link
Contributor

@lirantal lirantal commented Aug 8, 2019

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

@papb
Copy link
Member

papb commented Aug 8, 2019

What about this part of the readme?

Perhaps you should change it too to contain a link to the document you created?

@papb papb changed the title feat(security): add responsible disclosure policy docs(security): add responsible disclosure policy Aug 8, 2019
@papb papb added status: awaiting response For issues and PRs. OP must respond (or change something, if it is a PR). Maintainers have no action type: docs For issues and PRs. Things related to documentation, such as changes in the manuals / API reference. labels Aug 8, 2019
@lirantal
Copy link
Contributor Author

lirantal commented Aug 8, 2019

Indeed, I'll push an update.

@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #11300 into master will increase coverage by 0.76%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11300      +/-   ##
==========================================
+ Coverage   95.58%   96.34%   +0.76%     
==========================================
  Files          91       94       +3     
  Lines        8855     9057     +202     
==========================================
+ Hits         8464     8726     +262     
+ Misses        391      331      -60
Impacted Files Coverage Δ
lib/dialects/mariadb/index.js 100% <0%> (ø)
lib/dialects/mariadb/connection-manager.js 100% <0%> (ø)
lib/dialects/mariadb/query.js 87.87% <0%> (ø)
lib/dialects/abstract/query-generator.js 97.61% <0%> (+0.17%) ⬆️
lib/sequelize.js 95.95% <0%> (+0.62%) ⬆️
lib/query-interface.js 92.17% <0%> (+1.46%) ⬆️
lib/dialects/mariadb/data-types.js 100% <0%> (+49.01%) ⬆️
lib/dialects/mariadb/query-generator.js 97.87% <0%> (+87.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 488c048...bcc1a0e. Read the comment docs.

SECURITY.md Outdated Show resolved Hide resolved
@papb papb requested a review from sushantdhiman August 8, 2019 22:24
@papb papb added status: awaiting maintainer and removed status: awaiting response For issues and PRs. OP must respond (or change something, if it is a PR). Maintainers have no action labels Aug 9, 2019
@sushantdhiman
Copy link
Contributor

I have cleaned up Security.md a bit :)

@sushantdhiman sushantdhiman merged commit 29eb1c8 into sequelize:master Aug 11, 2019
Copy link
Contributor Author

@lirantal lirantal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunshinewyin I think some wording fixes are required but leaving it up to you :)

SECURITY.md Show resolved Hide resolved
SECURITY.md Show resolved Hide resolved
@lirantal lirantal deleted the patch-1 branch August 11, 2019 10:42
@lirantal
Copy link
Contributor Author

Sure thing. Left some comments on wording, let me know if you'd want a PR.

@sushantdhiman
Copy link
Contributor

Thanks @lirantal , de06ac3 fixed those issues

@lirantal
Copy link
Contributor Author

@sushantdhiman cool thanks! 👌

@sushantdhiman
Copy link
Contributor

🎉 This PR is included in version 5.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released type: docs For issues and PRs. Things related to documentation, such as changes in the manuals / API reference.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants