From fc53cdbfbbf312d501c03f4268637795e43131d7 Mon Sep 17 00:00:00 2001 From: Joel Bradshaw Date: Sat, 15 Jan 2022 01:12:09 -0800 Subject: [PATCH] fix: don't call overloaded versions of find functions internally (#13951) --- test/unit/model/find-one.test.js | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/test/unit/model/find-one.test.js b/test/unit/model/find-one.test.js index bed619a26eaa..01f8d0f25198 100644 --- a/test/unit/model/find-one.test.js +++ b/test/unit/model/find-one.test.js @@ -118,6 +118,23 @@ describe(Support.getTestDialectTeaser('Model'), () => { }); Model.findAll = sinon.stub(); + await Model.findOne(); + Model.findAll.should.not.have.been.called; + Sequelize.Model.findAll.should.have.been.called; + }); + it('should call internal findAll() method if findOne() is overridden', async () => { + const Model = current.define('model', { + unique1: { + type: DataTypes.INTEGER, + unique: 'unique', + }, + unique2: { + type: DataTypes.INTEGER, + unique: 'unique', + }, + }); + Model.findAll = sinon.stub(); + await Model.findOne(); Model.findAll.should.not.have.been.called; Sequelize.Model.findAll.should.have.been.called;