From 11e8cfaa8795a18d310c9ec192f61d24c39307e8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Eiras?= Date: Mon, 24 Jan 2022 13:58:37 +0100 Subject: [PATCH] docs(mssql): clarify in comments and docs supports MS SQL versions (#13989) --- docs/manual/other-topics/dialect-specific-things.md | 6 +++++- docs/manual/other-topics/upgrade-to-v7.md | 6 ++++++ lib/dialects/mssql/index.js | 8 +++++++- 3 files changed, 18 insertions(+), 2 deletions(-) diff --git a/docs/manual/other-topics/dialect-specific-things.md b/docs/manual/other-topics/dialect-specific-things.md index ddb84142aa71..9cf9b961d3be 100644 --- a/docs/manual/other-topics/dialect-specific-things.md +++ b/docs/manual/other-topics/dialect-specific-things.md @@ -113,7 +113,11 @@ const sequelize = new Sequelize('database', 'username', 'password', { ### MSSQL -The underlying connector library used by Sequelize for MSSQL is the [tedious](https://www.npmjs.com/package/tedious) npm package (version 6.0.0 or above). +The supported versions of MS SQL are from MS SQL 2017 (version 14) up to the most recent version. + +#### Tedious + +The default underlying connector library used by Sequelize for MSSQL is the [tedious](https://www.npmjs.com/package/tedious) npm package. You can provide custom options to it using `dialectOptions.options` in the Sequelize constructor: diff --git a/docs/manual/other-topics/upgrade-to-v7.md b/docs/manual/other-topics/upgrade-to-v7.md index a348fa0e6529..07646f672738 100644 --- a/docs/manual/other-topics/upgrade-to-v7.md +++ b/docs/manual/other-topics/upgrade-to-v7.md @@ -30,3 +30,9 @@ sequelize.connectionManager.getConnection({ type: 'SELECT' }); // Do this: sequelize.connectionManager.getConnection({ type: 'read' }); ``` + +### Microsoft SQL Server Support + +Sequelize v7 fully supports MS SQL Server 2017 (version 14) onwards, up from 2012 (version 13) in +Sequelize v6, as this matches Microsoft's own [mainstream support]( +https://docs.microsoft.com/en-us/sql/sql-server/end-of-support/sql-server-end-of-life-overview?view=sql-server-ver15#lifecycle-dates). diff --git a/lib/dialects/mssql/index.js b/lib/dialects/mssql/index.js index 52c72926b4b7..74c8d3c41259 100644 --- a/lib/dialects/mssql/index.js +++ b/lib/dialects/mssql/index.js @@ -51,7 +51,13 @@ class MssqlDialect extends AbstractDialect { } } -MssqlDialect.prototype.defaultVersion = '12.0.2000'; // SQL Server 2014 Express, minimum supported version +// SQL Server 2017 Express (version 14), minimum supported version, all the way +// up to the most recent version. When increasing this version, remember to +// update also the minimum version in the documentation at +// docs/manual/other-topics/dialect-specific-things.md +// and set the relevant years for the mssql Docker images in the ci.yml file at +// .github/workflows/ci.yml +MssqlDialect.prototype.defaultVersion = '14.0.1000'; MssqlDialect.prototype.Query = Query; MssqlDialect.prototype.name = 'mssql'; MssqlDialect.prototype.TICK_CHAR = '"';