Adding Commandline Interface #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of just checking t1, we also check t2, to ensure we survive diffs where both the old and the new value can be None. Also, as far as I can understand the code, we exit upon reporting a result in the case of a type mismatch rather than continuing the diff code (that way we don't need each type-specific differ to handle incorrect types – None, in this case). Further iteration from 47a141f. The expanded test coverage fails on master.
Improve ignoring of NoneType in diff
This reverts commit 46db2aa.
epsilon is now passed with math_epsilon. math_close boolean is removed. added warning for use in conjunction with ignore_order
add math_epsilon for number diffs that are close
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
=========================================
Coverage ? 99.63%
=========================================
Files ? 13
Lines ? 2734
Branches ? 0
=========================================
Hits ? 2724
Misses ? 10
Partials ? 0 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Commandline Interface