Can now get just a list of ascii fonts and ascii arts #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaTinkerer
changed the title
sepandhaghighi
requested changes
May 16, 2022
Codecov Report
@@ Coverage Diff @@
## dev #202 +/- ##
=======================================
Coverage 90.91% 90.91%
=======================================
Files 1 1
Lines 275 275
Branches 74 74
=======================================
Hits 250 250
Misses 23 23
Partials 2 2 Continue to review full report at Codecov.
|
sepandhaghighi
approved these changes
May 17, 2022
There was a problem hiding this comment.
LGTM 💯
@sadrasabouri Please review this PR, if everything is okay Squash/Merge it after approval 🚀
sadrasabouri
approved these changes
May 17, 2022
There was a problem hiding this comment.
Seems OK to me, too.
Congratulations for your first PR on art, @N00bkoder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Adds
ASCII_FONTSandASCII_ARTStoart_param.pyAccesses list of all ascii fonts and ascii arts respectively
Any other comments?