sensu-agent --labels cmdline arg not working as expected

[jspaleta]

Expected Behavior

sensu-agent start --labels "hey=now" should populate entity metadata labels with "hey" key set to "now" value

Current Behavior

When --labels "hey=now" is used sensuctl entity info shows labels as null... even if labels are set in agent.yaml

Possible Solution

Steps to Reproduce (for bugs)

1. config agent.yaml with labels defined

cat agent.yml
---
##
# agent configuration
##
subscriptions: "dev"
labels:
  pumpkin: spice 
  chia: latte

2. start agent:
   sudo -u sensu sensu-agent start
3. confirm labels are populated with sensuctl entity info --format yaml

type: Entity
spec:
  deregister: false
  deregistration: {}
  entity_class: agent
  last_seen: 1542327093
  metadata:
    annotations: null
    labels:
      chia: latte
      pumpkin: spice
    name: sensu-localdomain
    namespace: default

4. start agent with --labels "hey=now"
   sudo -u sensu sensu-agent start --labels "hey=now"
5. use sensuctl entity info --format yaml and see labels are null

type: Entity
spec:
  deregister: false
  deregistration: {}
  entity_class: agent
  last_seen: 1542327178
  metadata:
    annotations: null
    labels: null
    name: sensu-localdomain
    namespace: default

Your Environment

fedora 28
sensu-go beta8

[palourde]

Related: spf13/viper#608

[ghost]

I am also having this issue on MacOS, Kubernetes centos 7 docker image, and RHEL 7.

[ghost]

It looks like viper is fixed, can someone update viper?
spf13/viper#200

[palourde]

@maskeda While the issue we are having with the --labels & --annotations flags might have a similar underlying cause to spf13/viper#200, the problem appears to remain with Viper 1.3.2 because we are talking about two completely different functions, GetStringSlice vs GetStringMapString.

My understanding is that this problem still exists in Viper: spf13/viper#608

You mentioned in your PR that you were able to successfully test the --labels flag with Viper 1.3.2. Do you mind explaining how you did it?

Thanks!

[palourde]

Also related: spf13/cobra#778

[palourde]

This is now fixed for good!