This repository has been archived by the owner on Feb 24, 2023. It is now read-only.
Fix has_role compatibility in Symfony 3.4 #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Jul 5, 2019
|
This also solve our 403 issues. Thank you @ostrolucky |
|
Ours too. Thank you @ostrolucky |
|
Thank you @ostrolucky. |
fabpot
added a commit
that referenced
this pull request
Jul 8, 2019
This PR was merged into the 5.4.x-dev branch. Discussion ---------- Fix has_role compatibility in Symfony 3.4 Fixes #628 Looked into tests too, but didn't see any simple way to write a test for 3.4 only, while avoiding deprecations Commits ------- ec6f18e Fix has_role compatibility in Symfony 3.4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #628
Looked into tests too, but didn't see any simple way to write a test for 3.4 only, while avoiding deprecations