This repository has been archived by the owner on Feb 24, 2023. It is now read-only.
Fixed behaviour on Symfony 3.4 #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @tarlepp. |
fabpot
added a commit
that referenced
this pull request
Jul 3, 2019
This PR was squashed before being merged into the 5.4.x-dev branch (closes #626). Discussion ---------- Fixed behaviour on Symfony 3.4 Not 100% sure if this is the "proper" way to handle those event class changes properly - but at least now tests are ok with 3.4 and 4.3 - although I don't like to use that generic `KernelEvent` type on those listener classes - but didn't found another solution to fix that. If there is another solution for that I'm like to hear that - so that I could improve this PR. Related to #625 Commits ------- d5c3d4a Fixed behaviour on Symfony 3.4
|
Hmm, I see that construct signature is different with that one - As I said in my initial comment that I didn't like this solution - although all the tests are green with SF3.4 and 4.3. And that is why I asked if there was another solution to fix this - or is this something that cannot be fixed before SF5 to get support for SF3.4 and 4.3? I'm open for any ideas you might have. And really if there isn't solution to fix this, then this should be reverted imho. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not 100% sure if this is the "proper" way to handle those event class changes properly - but at least now tests are ok with 3.4 and 4.3 - although I don't like to use that generic
KernelEventtype on those listener classes - but didn't found another solution to fix that.If there is another solution for that I'm like to hear that - so that I could improve this PR.
Related to #625